Closed Bug 1194090 Opened 5 years ago Closed 4 years ago

[browser] Firefox Account sign in page

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(feature-b2g:2.5+)

RESOLVED FIXED
FxOS-S8 (02Oct)
feature-b2g 2.5+

People

(Reporter: yifan, Assigned: yifan)

References

Details

(Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick])

Attachments

(1 file)

Implement Firefox Account sign in page in TV browser.
Blocks: 1194091
Blocks: 1194092
Blocks: 1194094
Blocks: 1194096
Blocks: 1194097
Blocks: 1194098
Blocks: 1194104
Blocks: TV_FxAccount
No longer blocks: 1187830
No longer blocks: 1187840
No longer blocks: 1187838
Blocks: TV_Pocket
No longer blocks: TV_Pocket
feature-b2g: --- → 2.5+
Whiteboard: [ft:conndevices][partner-blocker]
Hi YiFan,
 Is bug 1193174 and 1193175 dup this one? Same one for login/logout?
Flags: needinfo?(yliao)
This one is for login and bug 1194104 is for logout. Yep they are dups...
Flags: needinfo?(yliao)
Duplicate of this bug: 1193174
Assignee: nobody → yliao
Target Milestone: --- → FxOS-S7 (18Sep)
Status: NEW → ASSIGNED
Blocks: 1202376
No longer blocks: 1202376
Comment on attachment 8657993 [details] [review]
[gaia] begeeben:1194090_firefox_account_sign_in > mozilla-b2g:master

Implemented sign in page draft UI. Please help to review, thanks!
Attachment #8657993 - Flags: review?(rexboy)
Attachment #8657993 - Flags: review?(rexboy) → review-
Comment on attachment 8657993 [details] [review]
[gaia] begeeben:1194090_firefox_account_sign_in > mozilla-b2g:master

* Change browser app type from privileged to certified.
* Add smart-button.
* Add firefox_account.js.
* Add Firefox Account sign in feature.
* Change default font size to 10px.
Attachment #8657993 - Flags: review- → review?(rexboy)
Blocks: 1203898
The code looks ok to me. But I got several errors when testing, they are:
1. The password I entered doesn't seem to be correctly registered. I changed my password once from firefox    
   account website. I'm not sure if it's problem from fx account server.
2. After clicking "confirm" on the registry confirm mail, the status didn't change respectively. I didn't find anywhere to do the 
3. After restarting B2G, my account didn't show up.

The patch is good to be landed, but be sure the problems have corresponding follow-up bugs.
Attachment #8657993 - Flags: review?(rexboy) → review+
Also I have some comments on Github. FxAccountsIACHelper.getAccounts has changed its name.
And let's sync about the sign-up flow after you come back.

Thanks for your effort!
Priority: -- → P1
Target Milestone: FxOS-S7 (18Sep) → FxOS-S8 (02Oct)
Hi YiFan,
Could you provide update for current status of this bug?
Thanks
Flags: needinfo?(yliao)
Merged into master:

https://github.com/mozilla-b2g/gaia/pull/31732
Flags: needinfo?(yliao)
Blocks: 1207481
Blocks: 1207483
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
See Also: → 1207483
See Also: → 1207481
Blocks: 1207488
See Also: → 1207488
(In reply to KM Lee [:rexboy] from comment #7)
> The code looks ok to me. But I got several errors when testing, they are:
> 1. The password I entered doesn't seem to be correctly registered. I changed
> my password once from firefox    
>    account website. I'm not sure if it's problem from fx account server.
> 2. After clicking "confirm" on the registry confirm mail, the status didn't
> change respectively. I didn't find anywhere to do the 
> 3. After restarting B2G, my account didn't show up.
> 
> The patch is good to be landed, but be sure the problems have corresponding
> follow-up bugs.

These bugs will be followed up in bug 1207481, bug 1207483 and bug 1207488.
Component: Gaia::TV → Gaia::TV::Browser
Whiteboard: [ft:conndevices][partner-blocker] → [ft:conndevices][partner-blocker][partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.