1194090 - [browser] Firefox Account sign in page

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

Description

[yifan [:yifan][:yliao]]

Implement Firefox Account sign in page in TV browser.

Comment 1

[Josh Cheng [:josh]]

Hi YiFan,
 Is bug 1193174 and 1193175 dup this one? Same one for login/logout?

Comment 2

[yifan [:yifan][:yliao]]

This one is for login and bug 1194104 is for logout. Yep they are dups...

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] begeeben:1194090_firefox_account_sign_in > mozilla-b2g:master

Comment 5

[yifan [:yifan][:yliao]]

Comment on attachment 8657993 [details] [review]
[gaia] begeeben:1194090_firefox_account_sign_in > mozilla-b2g:master

Implemented sign in page draft UI. Please help to review, thanks!

Comment 6

[yifan [:yifan][:yliao]]

Comment on attachment 8657993 [details] [review]
[gaia] begeeben:1194090_firefox_account_sign_in > mozilla-b2g:master

* Change browser app type from privileged to certified.
* Add smart-button.
* Add firefox_account.js.
* Add Firefox Account sign in feature.
* Change default font size to 10px.

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

The code looks ok to me. But I got several errors when testing, they are:
1. The password I entered doesn't seem to be correctly registered. I changed my password once from firefox    
   account website. I'm not sure if it's problem from fx account server.
2. After clicking "confirm" on the registry confirm mail, the status didn't change respectively. I didn't find anywhere to do the 
3. After restarting B2G, my account didn't show up.

The patch is good to be landed, but be sure the problems have corresponding follow-up bugs.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Also I have some comments on Github. FxAccountsIACHelper.getAccounts has changed its name.
And let's sync about the sign-up flow after you come back.

Thanks for your effort!

Comment 9

[Josh Cheng [:josh]]

Hi YiFan,
Could you provide update for current status of this bug?
Thanks

Comment 10

[yifan [:yifan][:yliao]]

Merged into master:

https://github.com/mozilla-b2g/gaia/pull/31732

Comment 11

[yifan [:yifan][:yliao]]

(In reply to KM Lee [:rexboy] from comment #7)
> The code looks ok to me. But I got several errors when testing, they are:
> 1. The password I entered doesn't seem to be correctly registered. I changed
> my password once from firefox    
>    account website. I'm not sure if it's problem from fx account server.
> 2. After clicking "confirm" on the registry confirm mail, the status didn't
> change respectively. I didn't find anywhere to do the 
> 3. After restarting B2G, my account didn't show up.
> 
> The patch is good to be landed, but be sure the problems have corresponding
> follow-up bugs.

These bugs will be followed up in bug 1207481, bug 1207483 and bug 1207488.