1219775 - The urlbar is not focused when a new tab is opened with Ctrl+T while the window is in DOM full screen mode

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Sami Jaktholm]

STR:
1. Go to https://developer.mozilla.org/samples/domref/fullscreen.html
2. Press Enter to enter full screen mode
3. Press Ctrl+T to open a new tab

What happens: The new tab opens but the urlbar is not focused.
What should happen: The urlbar is focused as if it would if you opened a new tab when the window is not in DOM fullscreen mode.

I can reproduce this issue in both Nightly and current release, Fx41, on Ubuntu 14.04.

Comment 1

[Jesse Ruderman]

I have the same problem on Mac, usually when I decide to pause a video to look something up.

Comment 10

[shalokshalom]

Since there are tons of duplications and because this issue is open for 4 years, despite the fact that it probably annoys the hell out of all who use the fullscreen mode and keyboard shortcuts, which is probably not too less of the userbase: Could somebody please increase the importance?

Thanks in advance

Comment 12

[Drew Willcoxon :adw]

I debugged this a little after working on bug 1610200. It looks like the front end takes all the same code paths it does when not in full-screen mode. The difference is that this conditional is false in full-screen mode but true when not in full screen: https://searchfox.org/mozilla-central/source/dom/html/HTMLInputElement.cpp#3039

I stopped debugging at that point, so I don't know why that is.

I tried adding a one-second timeout here, and that fixed it: https://searchfox.org/mozilla-central/rev/a4be2fbe9bd4f405c91cc16e4e3a80400f5a9301/browser/base/content/browser.js#2906 Full-screen mode is exited right above that. So we might be able to listen for the end of the full-screen transition and then do the select after that.

Comment 13

[Drew Willcoxon :adw]

I can't reproduce this on Windows... Comment 0 mentions Linux and I can reproduce it on macOS (like comment 1), so this is Linux and Mac only?

Comment 14

[Mathew Hodson]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

I can reproduce with the STR in comment 0 on Windows 10.

Comment 15

[Drew Willcoxon :adw]

Ah, actually I can too. I think I didn't follow the STR but used the View > Full Screen command instead. So this is all platforms. Thanks.

Comment 19

[:Gijs (he/him)]

Hey Steven, with your recent work on full screen, is this something you could pick up?

Comment 20

[Steven MacLeod [:smacleod]]

(In reply to :Gijs (he/him) from comment #19)

Hey Steven, with your recent work on full screen, is this something you could pick up?

Ya I can probably take a look soonish.

Comment 21

[Steven MacLeod [:smacleod]]

Attachment: Bug 1219775 - focus url bar when opening new tab from fullscreen. r=Gijs!

Comment 25

[cesar]

I have the same issue, it bugs the crap out of me. I happens in Windows 10/11 and in Ubuntu Linux, Firefox 94.0 . November 2021.

Comment 26

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:dao, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 27

[daniel.akerud]

Happens on Firefox 97.0.1 on Macos 12.2.1.

Comment 30

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 17 duplicates.
:dao, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 31

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Comment 32

[:Gijs (he/him)]

I'm going to up the severity here based on the fact that this is one of the most duped bugs in Firefox so it should be in the quality foundation pile.

Comment 33

[Neil Deakin]

Attachment: Bug 1219775 , focus the url bar when opening a new tab while in fullscreen mode, r=gijs

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad7fa1c3acaf
focus the url bar when opening a new tab while in fullscreen mode, r=Gijs

Comment 35

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ad7fa1c3acaf

Comment 36

[:Gijs (he/him)]

Neil, do you think this is safe for uplift, perhaps after verification by QA?

Comment 37

[Ed Lee :Mardak]

Did something change recently before this fix? I'm in full screen most of the time, and opening a new tab would allow me to type in a new url right away (probably until earlier this week?). But even with the change here, urlbar doesn't have focus on a new tab when in fullscreen.

Edit: nevermind, this bug is the regressing bug. Filed bug 1801168

Comment 38

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #36)

Neil, do you think this is safe for uplift, perhaps after verification by QA?

Given the regression, maybe not for now...

Comment 39

[Alexandru Trif, Desktop QA [:atrif] [PTO: 18-29 Sept, please ni? :mboldan]]

Reproduced the issue with Firefox 108.0a1 (2022-11-10) on Windows 10x64. After using Ctrl +T while in full screen a new tab is opened and the URL bar is not focused.
The issue is verified fixed with Firefox 109.0b3 on Windows 10x64, macOS 10.15 and Ubuntu 20.04. After following the STR from comment 0 the URL bar is focused.