123679 - Deleted bookmarks appear in search result window

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Kasumi]

tested 2002-02-04-11-trunk
OS = Win 98 JA 4.10.1998

1. Launch Navigator
2. Access to http://www.nfl.com/
3. Add this page to bookmark from toolbar or menubar
4. Delete this page from book mark
5. To search this page, select Manage bookmarks from toolbar or menubar
6. Select Edit/Find bookmarks or click Find in Sidebar/Bookmarks tab
7. Select "name" to first listbox, select "contains" to second listbox
   then type nfl to input box, click Find button
8. You will have deleted NFL.com in the search result window

Expected: deleted pages should not be searched.

Comment 1

[Chris Lyon]

Related to bug 93189 and/or bug 96789?

Comment 2

[Kasumi]

No.
93189 seems like rename problem.
96789 is mentioning about imported pages.
This bug is regardless of rename nor import. 

Comment 3

[Chris Lyon]

According to bug 93189 comment #1, not all the bookmark data is removed when 
the bookmark is deleted.  Maybe this data is what Find picks up?

Bug 96789 is a problem identical to this one, dealing specifically to Imported 
IE Favorites.  Maybe bug 96789 is a specific example of a more general problem?

Comment 4

[Kasumi]

>not all the bookmark data is removed when 
>the bookmark is deleted.  Maybe this data is what Find picks up?
I think so.

96789 is not good example because this is imported data.
We need to doubt about importing process.

Comment 5

[Chris Lyon]

removing self from cc list

Comment 6

[Jesus Cea]

Anybody still alive?. This bug is OLD, SERIOUS and should be "obvious".

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

While this would be nice to fix, I don't think we'd hold either the 1.4.x
release or the 1.5a release for it.

Adding dependency on bug 93189.

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Mass reassign of my non-Firefox bugs to [e-mail]

Comment 9

[Ray Booysen]

Reassigning as per Bug #32644

Comment 10

[(not reading, please use [e-mail] instead)]

this may have been fixed (in ff) by vlad's fix for #255255

Comment 12

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090715 SeaMonkey/2.1a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/d190d9b6ccd1
 +http://hg.mozilla.org/comm-central/rev/773809454cf2 + bug 503724 patch)

Comment 13

[Jens Hatlak (:InvisibleSmiley)]

I ported bug 255255 and bug 301048 and have a patch locally. The good news is that the core of this bug is already fixed in what I have so far, the even better news is that in the end it will hopefully enable/fix delete/cut while in search mode as well. :-) It just needs a little more work. Stay tuned.

Comment 14

[Jens Hatlak (:InvisibleSmiley)]

Attachment: proposed patch

For better comparison, this is the full diff of the patch from bug 255255:
<http://bonsai.mozilla.org/cvsview2.cgi?command=DIFF&subdir=mozilla%2Fbrowser%2Fcomponents%2Fbookmarks%2Fcontent%2FAttic&file=bookmarks.js&rev1=1.101&rev2=1.102&whitespace_mode=show&diff_mode=full>

This fixes/changes (Bookmark Manager and Bookmarks sidebar):
- bookmarks deleted in normal mode are also removed from Search mode view
- enables Delete and Cut (and their shortcuts) in Search mode

Test cases (Bookmark Manager and Bookmarks sidebar):
- create bookmark, verify it's visible in Search mode, delete it in normal mode, verify it's also gone in normal mode and Search mode
- create bookmark, verify it's visible in Search mode, delete it in Search mode, verify it's gone in Search mode and normal mode
- use cut instead of delete, then paste in normal or Search mode
- use Undo after delete or cut

Comment 16

[[e-mail]]

Comment on attachment 389572 [details] [diff] [review]
proposed patch

Sorry, I don't think this is the right way to fix this; strangely enough the hint came from the code that makes cut work in the Search view (which is a separate bug worth fixing) - the local search service needs to check that the search results have parents.

Comment 17

[[e-mail]]

Attachment: Proposed patch

Comment 18

[[e-mail]]

Pushed changeset 29283536a639 to comm-central.

Comment 19

[Jens Hatlak (:InvisibleSmiley)]

I'll continue with the rest of what my patch fixed in bug 81893 (Delete/Cut) and bug 509029 (newline added when copying bookmark).