PDF on ChinesePrintables.com displays glyphs instead of text
Categories
(Firefox :: PDF Viewer, defect)
Tracking
()
People
(Reporter: mcomella, Assigned: bdahl)
References
Details
Attachments
(2 files)
1.95 MB,
image/jpeg
|
Details | |
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details | Review |
- Visit http://www.chineseprintables.com/paper/rice_US.pdf
- Print from firefox
Expected: page prints as expected
Actual: "ChinesePrintables.com" and chinese characters on first line appears as glyphs: see attached
This works fine in Preview. I'm running FF 66.0a1 2019-01-27 on macOS 10.13.6.
Assignee | ||
Comment 1•5 years ago
|
||
I wasn't able to reproduce at first, but then went back after being distracted by some other stuff and was able to reproduce the issue. This lead me to realize it's time based and I can now reproduce consistently...
After 30s[1] pdf.js runs a cleanup method that removes any font faces that it added to the document to save memory. When you go to print Firefox creates a static clone of document and it's fonts, but at that time all the fonts have been removed from the document. As Firefox goes through and then prints each PDF page, pdf.js does try to reload the fonts, but they are unfortunately loaded into the original document, not the static clone.
To fix this we'll need to expose a way for pdf.js to load a font into the static clone during a mozPrintCallback.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Copy fonts loaded during a mozPrintCallback into the cloned document,
so they are available during printing.
Assignee | ||
Updated•5 years ago
|
Pushed by bdahl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ba40138a6d39 Fix font loading during mozPrintCallback. r=smaug
Comment 4•5 years ago
|
||
bugherder |
Reporter | ||
Comment 5•5 years ago
|
||
谢谢你!
Comment 7•5 years ago
|
||
hello,
can you please also check bug 1524825,
maybe this has the same reason?
some chars look simular when i print the sample of 1524825 (with 65)
mfg johannes
Comment 9•5 years ago
|
||
do you think you can fix in 65.0.1 and/or 66?
this a really bad bug and my collegues are ready very unhappy with this and some are printing very often pdf with FF...
johannes
Comment 24•5 years ago
|
||
Brendan, should this be considered for (at least) Beta uplift?
Assignee | ||
Comment 27•5 years ago
|
||
Comment on attachment 9041312 [details]
Bug 1524640 - Fix font loading during mozPrintCallback. r=smaug
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
User impact if declined
If a user wants to print a PDF and the PDF is not printed within 30 seconds of loading, the text will not print correctly. Given that tax season has started in the US, it'd be nice to have to fixed sooner rather than later.
Is this code covered by automated tests?
Yes
Has the fix been verified in Nightly?
Yes
Needs manual test from QE?
Yes
If yes, steps to reproduce
Follow steps in initial report, but wait more than 30s after the PDF loads to print the file. (You can print to a PDF file to test)
List of other uplifts needed
None
Risk to taking this patch
Medium
Why is the change risky/not risky? (and alternatives if risky)
There are some platform printing changes, but the new code path is only allowed for PDF.js.
String changes made/needed
Assignee | ||
Comment 28•5 years ago
|
||
Also, patch applies cleanly to beta and is looking good on try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dea73a6d47533b93e78080ac523bc2e1ebbaf4ff
Updated•5 years ago
|
Updated•5 years ago
|
Comment 29•5 years ago
|
||
Comment on attachment 9041312 [details]
Bug 1524640 - Fix font loading during mozPrintCallback. r=smaug
Seems worth a try, especially considering the point about tax season.
It would still be nice to have QE verify on nightly.
Updated•5 years ago
|
Comment 30•5 years ago
|
||
bugherder uplift |
Comment 31•5 years ago
|
||
Verified as fixed on the latest Nightly 67.0a1 (2019-02-25)
Will get back to check on Beta.
Comment 32•5 years ago
|
||
Hi,
I've verified this issue on Windows 10 / Mac OS 10.13 / Ubuntu 18.04.1 using Firefox Beta 66b11(20190225143245) as well and it is fixed.
Comment 33•5 years ago
|
||
However bugs which are marked at dups still don't work, eg 1523991, 1523667, 1524367.
67.0a1 (2019-02-25) (64 bits) Macos 10.13.3
I am reporter of 880181, similar issues. total corruption of printed documents
Assignee | ||
Comment 34•5 years ago
|
||
(In reply to AM from comment #33)
However bugs which are marked at dups still don't work, eg 1523991, 1523667, 1524367.
67.0a1 (2019-02-25) (64 bits) Macos 10.13.3
I am reporter of 880181, similar issues. total corruption of printed documents
Thanks for bringing this up. Those bugs were mistakenly lumped into this bug fix. I've opened a new bug to address those as well (bug 1530881).
Updated•5 years ago
|
Description
•