Closed Bug 16018 Opened 25 years ago Closed 25 years ago

Images draw through on to the menus

Categories

(Core :: XUL, defect, P2)

Product:
Core
Component:
XUL
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: pavlov, Assigned: pavlov)

References

Details

I can't reproduce this in viewer (unless I load something with boxes). There was a bug in the unix drawing code that wasn't checked in the clip region before it drew an image and was just overwriting the clip region. I have fixed this now, but there is still the problem of nsIRenderingContext::DrawImage() being called when there is an empty clip region. Now, the reason there is an empty clip region is because it shouldn't be drawing these images at all. This is easy to see with xpmenus because the images from the toolbar under them try to draw on the menus.
Assignee: evaughan → pavlov
Summary: Boxes cause images to be drawn that shouldn't be drawn → [DOGFOOD] Boxes cause images to be drawn that shouldn't be drawn
Whiteboard: porkjockey task
Target Milestone: M11
Whiteboard: porkjockey task → [PDT+]porkjockey task
Putting on [PDT+] radar.
Blocks: 16950
mass-moving most m11 bugs to m12
Severity: normal → major
Status: NEW → ASSIGNED
Priority: P3 → P2
Summary: [DOGFOOD] Boxes cause images to be drawn that shouldn't be drawn → [DOGFOOD] Images draw through on to the menus
*** Bug 18290 has been marked as a duplicate of this bug. ***
Whiteboard: [PDT+]porkjockey task → [PDT+] 12/3/99
Not all images shine through all menus. In Browser window: Stop button shines though File and Edit menu (oddly enough not though other menus) In MailNewswindow: In File and in help menus shine toolbaricons through Linux build 20/11
Whiteboard: [PDT+] 12/3/99 → 12/3/99
Per request frum trudelle, removing PDT+ annotation to force reconsideration. His assertion is that this bug is now fixed enough that it is not a dogfood stopper.
Whiteboard: 12/3/99 → [PDT-]12/3/99
Putting on PDT- radar. Not a dogfood blocker.
*** Bug 19155 has been marked as a duplicate of this bug. ***
*** Bug 20278 has been marked as a duplicate of this bug. ***
*** Bug 20308 has been marked as a duplicate of this bug. ***
adding myself to cc: list since this affects mail windows.
*** Bug 19921 has been marked as a duplicate of this bug. ***
Whiteboard: [PDT-]12/3/99 → [PDT-]
Target Milestone: M12 → M13
moving to m13
*** Bug 18831 has been marked as a duplicate of this bug. ***
adding self to cc list as it'd occur in my area...
*** Bug 17764 has been marked as a duplicate of this bug. ***
*** Bug 22211 has been marked as a duplicate of this bug. ***
*** Bug 15986 has been marked as a duplicate of this bug. ***
*** Bug 19520 has been marked as a duplicate of this bug. ***
*** Bug 22505 has been marked as a duplicate of this bug. ***
cc amusil,prass, scalkins as this affects Aim as well.
*** Bug 22461 has been marked as a duplicate of this bug. ***
*** Bug 22728 has been marked as a duplicate of this bug. ***
*** Bug 17245 has been marked as a duplicate of this bug. ***
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
beard just checked in a fix. he rocks.
Status: RESOLVED → VERIFIED
VERFIED Fixed with 2000011808 RH6 build
The problem is still there in a 1/21 pull on solaris/native. If you mouse back and forth across the menus, the navigation buttons are rendered over the menus.
Status: VERIFIED → REOPENED
I still see this on linux with 20000121 builds using aim->file menu.
I'd love some independent verification on this but by my examination this is a REGRESSION. My 2000011808 build does not show the error and neither does my 2000012008 build from yesterday. Yet, as duly pointed out the bug does reappear in my 2000012108 build. So to me at least, it looks like somebody checked in yesterday and broke this again.
Resolution: FIXED → ---
Backing out beard's change 3.18 yesterday to mozilla/view/src/nsViewFactory.cpp fixes this problem. Adding beard to the CC list.
beard, was your stuff backed out?
yes, beard backed his stuff out. he has a patch that he is going to check in real soon now that fixes this.
moving to m14
Target Milestone: M13 → M14
Moving from leftover dogfood to beta1 radar
Keywords: beta1
Summary: [DOGFOOD] Images draw through on to the menus → Images draw through on to the menus
Whiteboard: [PDT-]
This should be fixed now, both in the M13 branch, and in M14 tip.
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
claudius, can you verify today please?
Target Milestone: M14 → M13
VERIFIED fixed for 2000013114 linux builds.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.