Closed Bug 1690842 Opened 3 years ago Closed 3 years ago

Disable native theme by default in Nightly on macOS

Categories

(Core :: Widget: Cocoa, task, P2)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: spohl, Assigned: spohl)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [not-a-fission-bug][mac:nonnativetheme])

Attachments

(1 file)

This bug is to track bugs that have to be addressed before non-native theming can be enabled by default in Nightly on macOS.

Depends on: 1690848
Depends on: 1690879
Depends on: 1690891
Depends on: 1690895
Depends on: 1690906
Depends on: 1691141
Depends on: 1691142
Depends on: 1691148
Depends on: 1691150

Non-native theming on macOS doesn't block Fission MVP.

Whiteboard: [not-a-fission-bug]
Depends on: 1693346
Depends on: 1693426
Depends on: 1693471
Whiteboard: [not-a-fission-bug] → [not-a-fission-bug][mac:nonnativetheme]
Blocks: 1562052
Depends on: 1693675
Depends on: 1693688
Depends on: 1693690
Depends on: 1693880
Depends on: 1693895
Depends on: 1693950
Depends on: 1693951
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Blocks: 1571386
Pushed by spohl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6cd9ff9eca2
Disable the native theme in content on macOS. r=mstange
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Regressions: 1694299

== Change summary for alert #28905 (as of Wed, 24 Feb 2021 12:59:44 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
3% Heap Unclassified macosx1014-64-shippable-qr tp6 101,727,255.22 -> 98,616,425.14
3% Heap Unclassified macosx1014-64-shippable-qr tp6 101,235,098.92 -> 98,493,996.85

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28905

== Change summary for alert #29028 (as of Wed, 03 Mar 2021 11:17:14 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
5% amazon LastVisualChange macosx1014-64-shippable-qr cold nocondprof webrender 3,344.62 -> 3,192.50

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29028

Regressions: 1696915
Regressions: 1696988
No longer depends on: 1699918
Regressions: 1708326

FYI: This "regressed" the UI in connect.garmin.com
see Bug 1708326 for details.
And we should keep an eye on other sites "breaking" or not tolerating the size change of the widget.
Chrome is using auto-hide on the arrow for input type number which makes it easier to get a pass on the UI being not resilient enough on the garmin site.

Blocks: 1200559
Regressions: 1716567
Regressions: 1731366
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: