Closed Bug 1728594 Opened 2 months ago Closed 1 month ago

Firefox 91.0.2 64bit. Some website links will not open in same window.

Categories

(Core :: Privacy: Anti-Tracking, defect)

Firefox 91
defect

Tracking

()

VERIFIED FIXED
94 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 93+ verified
firefox91 --- wontfix
firefox92 --- wontfix
firefox93 --- verified
firefox94 --- verified

People

(Reporter: matthewkettle, Assigned: twisniewski)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Using Firefox 91.0.2 64bit on Windows 10. Some website links will not open in same window.

URL example: https://www.wickes.co.uk/search?text=bricks

Want to clink on a brick link nothing opens (https://www.wickes.co.uk/Marshalls-Red-Perforated-Engineering-Brick---215-x-100-x-65mm/p/252223)

Cleared cache and cookies etc and turned off hardware acceleration and opened Firefox in safe mode still same problem.
Checked Firefox config settings for opening links and all seem OK.
This is annoying as links for some websites need to keep opening link in new window.

Today created a new profile using the about:profiles page.
Tested URL https://www.wickes.co.uk/search?text=bricks and clicked on link https://www.wickes.co.uk/Marshalls-Red-Perforated-Engineering-Brick---215-x-100-x-65mm/p/252223 and it opened OK in same Firefox window.
However after that updated some settings in Firefox
Set custom URL HTML homepage
Send web sites a “Do Not Track” signal that you don’t want to be tracked --> Always
Delete cookies and site data when Firefox is closed
Do not save Logins and Passwords
History Firefox will --> Never remember history

Restarted Firefox and checked link above again and still cannot click/open link https://www.wickes.co.uk/Marshalls-Red-Perforated-Engineering-Brick---215-x-100-x-65mm/p/252223 or https://www.virginactive.co.uk/login by clinking on the hyperlink on webpage.

Please can this be looked into as clicking on a link is essential for a web browser to operate. Would this be fixed in a Firefox update or is it just my profile/settings? All these links used to work on 1-3 previous older versions of Firefox.

Actual results:

Using Firefox 91.0.2 64bit. Some website links will not open in same window.

URL example: https://www.wickes.co.uk/search?text=bricks

Want to clink on a brick link nothing opens (https://www.wickes.co.uk/Marshalls-Red-Perforated-Engineering-Brick---215-x-100-x-65mm/p/252223)

Cleared cache and cookies etc and turned off hardware acceleration and opened Firefox in safe mode still same problem.
Checked Firefox config settings for opening links and all seem OK.
This is annoying as links for some websites need to keep opening link in new window.

Today created a new profile using the about:profiles page.
Tested URL https://www.wickes.co.uk/search?text=bricks and clicked on link https://www.wickes.co.uk/Marshalls-Red-Perforated-Engineering-Brick---215-x-100-x-65mm/p/252223 and it opened OK in same Firefox window.
However after that updated some settings in Firefox
Set custom URL HTML homepage
Send web sites a “Do Not Track” signal that you don’t want to be tracked --> Always
Delete cookies and site data when Firefox is closed
Do not save Logins and Passwords
History Firefox will --> Never remember history

Restarted Firefox and checked link above again and still cannot click/open link https://www.wickes.co.uk/Marshalls-Red-Perforated-Engineering-Brick---215-x-100-x-65mm/p/252223 or https://www.virginactive.co.uk/login by clinking on the hyperlink on webpage.

Please can this be looked into as clicking on a link is essential for a web browser to operate. Would this be fixed in a Firefox update or is it just my profile/settings? All these links used to work on 1-3 previous older versions of Firefox.

Expected results:

Please can this be looked into as clicking on a link is essential for a web browser to operate. Would this be fixed in a Firefox update or is it just my profile/settings? All these links used to work on 1-3 previous older versions of Firefox.

The Bugbug bot thinks this bug should belong to the 'Core::Graphics' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Graphics
Product: Firefox → Core

Experiencing the exact same issues.

Hi Matthew, thanks for the bug report. Could you try resetting each of those settings to the default one by one to test which one exactly causes the issue?

Mark, do you have those same settings changed?

Flags: needinfo?(matthewkettle)
Flags: needinfo?(markk)

Resetting this to untriaged as it seems unlikely to be a graphics issue (I presume the bot saw "hardware acceleration" and sent it this way)

Component: Graphics → Untriaged
Product: Core → Firefox

Hi!
I was able to reproduce it on latest Nightly version 93.0a1 (2021-09-03)(64-bit) on Windows 10.
I just only set this pref: History Firefox will --> Never remember history (About:preferences#privacy - History > Firefox will)

I've run mozregression and I found this pushlog_URl: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cd54d705a55dcb037a99b25d89475fba2bafe795&tochange=3b1ecfe6403f101872a49cd1a8e1606c455c4761
I'll change flags accordingly.
Thanks!

Severity: -- → S3
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → no
Ever confirmed: true
Component: Untriaged → Preferences

Glandium, this bug came up in the regression triage meeting today, could this possibly be caused by your push on June 15th in the regression range in Comment 5?

Flags: needinfo?(mh+mozilla)

I don't think so.

Flags: needinfo?(mh+mozilla)

Hello All
Not fixed in Firefox upgrade 92.0 (64bit) as you know. Do you have all the info you need to fix the bug in terms of Firefox settings and being able to recreate this bug etc? Cannot wait for this fix! Might be fixed in Firefox 94.0?

Flags: needinfo?(matthewkettle)

Hm... none of the commits in the range from comment 5 looks particularly suspicious... Marcela, are you certain this is the regression range?

Flags: needinfo?(marcela.calderon)

(In reply to Mike Conley (:mconley) (:⚙️) from comment #9)

Hm... none of the commits in the range from comment 5 looks particularly suspicious... Marcela, are you certain this is the regression range?

Yes, I'm certainly. Just in case, I will run it again.

Flags: needinfo?(marcela.calderon)

Hey Matthew,

I wonder if this is related to the Enhanced Tracking Protection patch in https://hg.mozilla.org/integration/autoland/rev/2e82d85e50b4646515359f9938d8c882e66f9d36...

If you click on the shield icon in the URL bar on the broken site, does the panel say that "Enhanced tracking protection is ON" for the site? If so, can you toggle it to off, reload, and see if that fixes it? If so, we can direct this to the WebCompat team.

Flags: needinfo?(matthewkettle)

Actually, I just reproduced it myself. This definitely seems related to ETP - disabling it on the page causes navigation to work.

Hey twisniewki, any idea what's happening here? A shim problem?

Component: Preferences → Privacy: Anti-Tracking
Flags: needinfo?(twisniewski)
Flags: needinfo?(matthewkettle)
Flags: needinfo?(markk)
Product: Firefox → Core
Regressed by: 1713687

(In reply to Marcela from comment #11)

Mozregression Bisecting on mozilla-central [2021-03-13 - 2021-09-13]
Push log: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cd54d705a55dcb037a99b25d89475fba2bafe795&tochange=62ae9b62d18e332ef5670b14e17bcf238c80ec7f

Thanks, this regression window was critical in finding the right component. Much appreciated.

After some digging around, it turns out that gtm.js relies on their dataLayer.push method returning true, otherwise it prevents the default action when tracked links are clicked. I'm very surprised that such breakage hasn't been more widely reported, but the fix is thankfully trivial. I'll attach a patch here ASAP.

Flags: needinfo?(twisniewski)
Duplicate of this bug: 1725887
Duplicate of this bug: 1731042
Regressions: 1730879
Duplicate of this bug: 1730879
Regressions: 1728771
Duplicate of this bug: 1728771
Regressions: 1727880
Duplicate of this bug: 1727880
  • gpt.js expends dataLayer.push to return true, or it will cancel clicks on the relevant tracked links.
Assignee: nobody → twisniewski
Status: NEW → ASSIGNED
Pushed by twisniewski@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/105859612c91
fix a SmartBlock regression which causes some site links to not be clickable; r=johannh,ksenia,webcompat-reviewers
Duplicate of this bug: 1728237
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Duplicate of this bug: 1726976

The patch landed in nightly and beta is affected.
:twisniewski, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
If yes, don't forget to request an uplift for the patches in the regressions caused by this fix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(twisniewski)
Duplicate of this bug: 1726718

Comment on attachment 9241852 [details]
Bug 1728594 - fix a SmartBlock regression which causes some site links to not be clickable; r?johannh,ksenia

Beta/Release Uplift Approval Request

  • User impact if declined: Links on many pages will be broken in private browsing mode and when strict ETP is enabled.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Open a private browsing window.
  1. Visit https://www.wickes.co.uk/search?text=bricks
  2. Click on any product/brick.
  3. Confirm that the browser navigates to the brick's page, rather than the link being broken.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial patch to a system addon script.
  • String changes made/needed:
Flags: needinfo?(twisniewski)
Attachment #9241852 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9241852 [details]
Bug 1728594 - fix a SmartBlock regression which causes some site links to not be clickable; r?johannh,ksenia

Low risk fix to a widely reported webcompat issue. Approved for uplift in 93 beta 8, Thanks.

(On a side note, I think that a webcompat bug with 8 duplicates should probably have a higher severity than S3)

Attachment #9241852 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Seems like we should probably take this on ESR91 as well.

Flags: needinfo?(twisniewski)

Comment on attachment 9241852 [details]
Bug 1728594 - fix a SmartBlock regression which causes some site links to not be clickable; r?johannh,ksenia

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: The user impact seems relatively large, and the patch/fix is simple.
  • User impact if declined: Links on many pages will be broken in private browsing mode and when strict ETP is enabled.
  • Fix Landed on Version: 93
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial patch to a system addon script.
  • String or UUID changes made by this patch:
Flags: needinfo?(twisniewski)
Attachment #9241852 - Flags: approval-mozilla-esr91?
QA Whiteboard: [qa-triaged]
Duplicate of this bug: 1727104
Duplicate of this bug: 1727336
Duplicate of this bug: 1726293

[Tracking Requested - why for this release]: some website link does not work if ETP strict or PBM.

Please consider to uplift this to 91esr.

Reproduced with 93.0a1 (20210901214553) on Windows 10x64 and STR from comment 28.
Verified fixed with Firefox 93.0b8 (20210921185902) and 94.0a1 (20210922094736) on Windows 10x64, macOS 10.15 and Ubuntu 21.04.

Comment on attachment 9241852 [details]
Bug 1728594 - fix a SmartBlock regression which causes some site links to not be clickable; r?johannh,ksenia

Approved for 91.2esr.

Attachment #9241852 - Flags: approval-mozilla-esr91? → approval-mozilla-esr91+

Verified fixed with Firefox 91.2.0esr (20210923162219) using STR from comment 28 on Windows 10x64, macOS 10.15 and Ubuntu 21.0.4.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.