1824889 - Unread message badge on taskbar icon does not go away when message has been read

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect, P3)

Description

[todor]

Steps to reproduce:

1. Add same IMAP account to Thunderbird (on windows) and to smartphone (android in my case).
2. Receive email on that account. Wait for notification on both Thunderbird and smartphone.
3. Read or delete the email on the smart phone. Wait some time to sync the changes.

Actual results:

4. Notification dot on Thunderbirds icon in tray bar is still there and will not disappear until I open Thunderbird and go over the email address (which appears as bold). Then the notification disappears and the mailbox is not bold any more.

Expected results:

Notification for new email on Thunderbird should disappear once it sync the mailbox content without needing me to open it and click over the mailbox.

Comment 5

[Wayne Mery (:wsmwk)]

Is bug 1801078 a duplicate?

Comment 6

[Wayne Mery (:wsmwk)]

Other bug reports https://mzl.la/3X2zEPS

Comment 7

[Wayne Mery (:wsmwk)]

Better query https://mzl.la/3J7g5As - but these are not all about the dot.

Comment 9

[Celso]

I have the same problem on 115.0, even if I read the message on TB, but the icon stays as if the new message is not read.
When selecting the same or another folder, the icon goes back to normal.

Comment 10

[Francesco]

More duplicates: Bug 1843837, bug 1843766 and bug 1843734. There's a suggestion in bug 1843734 comment #3.

Comment 11

[bugzilla]

(In reply to Celso from comment #9)

I have the same problem on 115.0, even if I read the message on TB, but the icon stays as if the new message is not read.
When selecting the same or another folder, the icon goes back to normal.

I had this before and still have it after upgrading to 115. Also, requires changing folder to clear the badge count.

Comment 20

[Martin Pecka]

For me, this used to work on 102 (Win10) but started to behave as described here after the update to 115.

Comment 21

[phil]

This bug is different to the one I submitted a couple of years ago. (With which it has been merged.)

The steps required to reproduce are quite different.

My report was about folders within a single account not being handled correctly (as, it appears, were several others that have been incorrectly merged with this). It has also existed for many years and has nothing to do with W10/W11.

It seems that bugs are being merged without the person merging properly understanding their nature.

Comment 22

[Martin Pecka]

Oh, you're actually right. I went here from https://bugzilla.mozilla.org/show_bug.cgi?id=1849620 with the idea of not commenting on a dupe, but reading your STR once more carefully, I agree those two are actually different bugs (with similar manifestation).

@john.guitarman could you please remove the dupe status of https://bugzilla.mozilla.org/show_bug.cgi?id=1849620 ?

Comment 23

[Magnus Melin [:mkmelin]]

Attachment: Bug 1824889 - Initialize MailNotificationManager before getting mail. r=leftmostcat

No silver bullet, but I think time of initialization may be somewhat incorrect so the code gets confused.
Modernize NewMailNotificationService.
Some changes insipired by https://github.com/Betterbird/thunderbird-patches/blob/main/115/features/02b-feature-Windows-systray-tooltip.patch

Comment 24

[betterbird.project+9]

Please correct this hunk:

    if (this.countNew) {
      this.initUnreadCount();
    }

It needs to be if (!this.countNew) {, see
https://github.com/Betterbird/thunderbird-patches/blob/8b2cf4bc70910088a8dac6d9c3a8377b59ed9f5a/115/features/02b-feature-Windows-systray-tooltip.patch#L117

The logic is: If we're counting new messages, we don't need to traverse all folders and count unread messages. Since counting new message is the default on Windows and Linux, that's a definite startup performance improvement.

Comment 25

[betterbird.project+9]

Equally, this hunk needs fixing: if (subject == "profile-before-change") { - it should be topic like it was before.

Comment 26

[Magnus Melin [:mkmelin]]

So this patch will probably fix some cases but unclear if all.
Maybe easiest still to close this bug now and continue in one of the other see also bugs if needed,

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/28a5389aa264
Initialize MailNotificationManager before getting mail. r=leftmostcat

Comment 28

[Magnus Melin [:mkmelin]]

Attachment: Bug 1824889 - follow-up, make unread setter available for tests. r=#thunderbird-reviewers

Comment 29

[Intermittent Failures Robot]

2 failures in 3267 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• macosx1015-64-qr: 1
  • opt: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1824889&startday=2023-09-04&endday=2023-09-10&tree=all

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c21caa5b4d1c
follow-up, make unread setter available for tests. r=babolivier

Comment 31

[Wayne Mery (:wsmwk)]

Ready for beta?

Comment 32

[Magnus Melin [:mkmelin]]

Comment on attachment 9350798 [details]
Bug 1824889 - Initialize MailNotificationManager before getting mail. r=leftmostcat

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: could help with buggy mail notification behavior
Testing completed (on c-c, etc.): daily
Risk to taking this patch (and alternatives if risky): fairly safe, but should get some baking

Comment 33

[Wayne Mery (:wsmwk)]

Comment on attachment 9350798 [details]
Bug 1824889 - Initialize MailNotificationManager before getting mail. r=leftmostcat

[Triage Comment]
Approved for beta

Comment 34

[Wayne Mery (:wsmwk)]

Comment on attachment 9352397 [details]
Bug 1824889 - follow-up, make unread setter available for tests. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 35

[Daniel Darnell [:dandarnell]]

Thunderbird 118.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/f02be8253be3
https://hg.mozilla.org/releases/comm-beta/rev/28534de2b560

Comment 36

[Wayne Mery (:wsmwk)]

Comment on attachment 9350798 [details]
Bug 1824889 - Initialize MailNotificationManager before getting mail. r=leftmostcat

[Triage Comment]
Approved for esr115

Comment 37

[Wayne Mery (:wsmwk)]

Comment on attachment 9352397 [details]
Bug 1824889 - follow-up, make unread setter available for tests. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 38

[Daniel Darnell [:dandarnell]]

Thunderbird 115.2.3:
https://hg.mozilla.org/releases/comm-esr115/rev/6387bc3712d1
https://hg.mozilla.org/releases/comm-esr115/rev/454384d645a2