199386 - Set Default Browser registers pref.xul as Preferences entry in WinXP Start Menu (Internet Shortcuts opens Seamonkey preferences/wrong preferences)

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[David Tenser [:djst]]

If you register Phoenix as the default web browser from the Options window, it
will also register chrome://communicator/content/pref/pref.xul as an entry for
the preferences. 

HKEY_LOCAL_MACHINE\SOFTWARE\Clients\StartMenuInternet\PHOENIX.EXE\shell\properties\command
(Default) = E:\PHOENIX\PHOENIX.EXE-chrome
"chrome://communicator/content/pref/pref.xul"

First of all, it's the old preferences window, not the new Options window.
Second, it's loaded in a normal browser window, making the dialog huge and
resizable.

Comment 1

[Pierre Chanial]

*** This bug has been marked as a duplicate of 198679 ***

Comment 2

[Pierre Chanial]

arg, reopening.

Comment 3

[Pierre Chanial]

and taking.
(fixed in bug 202984)

Comment 4

[Bill Mason]

*** Bug 213185 has been marked as a duplicate of this bug. ***

Comment 5

[Tse-Wen Tom Wang]

This bug may be more serious than it looks, as one extension, PrefBar, ended up
modifying the preference entry in WinXP Start Menu instead of in pref.xul.  But
then PrefBar was designed to work with the older pref window.

Comment 6

[Tse-Wen Tom Wang]

This bug may be more serious than it looks, as one extension, PrefBar, ended up
modifying the preference entry in WinXP Start Menu instead of in pref.xul.  But
then PrefBar was designed to work with the older pref window.

Comment 7

[Will Levine]

This is due this code in
http://lxr.mozilla.org/seamonkey/source/xpfe/components/winhooks/nsWindowsHooksUtil.cpp#435
.  This code is designed for Seamonkey.  I think to fix this problem we would
have to fork winhooks to use a different version for Firebird.  I don't really
know if we want to do this.  It seems like its a lot of stuff to take care of
just for a couple minor bugs.  Also this will probably have to be fixed when
firebird becomes the default browser, so it might be better to wait.  Forrking
winhooks would probably also fix the bug where Mozilla and Firebird attempt to
associate themselves with the same file types (can't find the bug # at the moment).

Comment 8

[Bill Mason]

*** Bug 213629 has been marked as a duplicate of this bug. ***

Comment 9

[Bill Mason]

*** Bug 214045 has been marked as a duplicate of this bug. ***

Comment 10

[Bill Mason]

Tweaking summary to try and help cut dups down.

Comment 11

[Mike Connor [:mconnor]]

taking QA contact, sorry about the bugspam

Comment 12

[Tim Hill]

After installing Firebird 0.6.1, the Start Menu displays the old Mozilla-style
icon (http://themes.mozdev.org/img/moz13.png), rather than the new Firebird icon
(http://mozilla.org/frontpage/downloadIconFirebird.gif). Is this part of the
same bug, or a different one?

Comment 13

[Bill Mason]

*** Bug 215464 has been marked as a duplicate of this bug. ***

Comment 14

[Sunil Garg]

Attachment: Screenshot (XP)

Comment 15

[Simon Paquet [:sipaq]]

*** Bug 216903 has been marked as a duplicate of this bug. ***

Comment 16

[Mike Connor [:mconnor]]

Short term nasty workaround is to have a copy of the correct pref.xul in this
place.  I have tested this and it seems to work okay.  We need to fix or fork
setWindowsXP and the rest of the winhooks stuff to make this work "properly"
(allow different pref URLs).

Comment 17

[Oleg Sidletskiy]

*** Bug 220834 has been marked as a duplicate of this bug. ***

Comment 18

[Jesse Ruderman]

*** Bug 221226 has been marked as a duplicate of this bug. ***

Comment 19

[Pierre Chanial]

Attachment: #ifdef'ing the chrome url

Comment 20

[Brendan Eich [:brendan]]

p_ch: how about requesting a review from ben too?

/be

Comment 21

[timeless]

Comment on attachment 134961 [details] [diff] [review]
#ifdef'ing the chrome url

that's ok. i explained to pch why this is a bad fix.

we should have a way for an arbitrary app (e.g. mail) to open preferences. and
the winxp hooks would benefit from it. i might post a patch for this.

Comment 22

[Asa Dotzler [:asa]]

->Ben
Ben, this seems like a good integration bug to get fixed. Can you take a look at
it and target this to some pre-1.0 milestone?

Comment 23

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 134961 [details] [diff] [review]
#ifdef'ing the chrome url

This seems OK to me. r=[e-mail]

Comment 24

[Pierre Chanial]

-> me

Comment 25

[Pierre Chanial]

the browser pref dialog is not supposed to be accessed by the extensions (such
as domi, chatzilla and venkman) and the XP start menu is only specific to
internet browsers. Therefore, there is no need for an external way to access the
xul app pref dialog.

Comment 26

[Bill Mason]

Verified fixed 20031128 PC/WinXP

Comment 27

[Oleg Sidletskiy]

*** Bug 227042 has been marked as a duplicate of this bug. ***

Comment 28

[Ali Ebrahim]

As a pre-emptive comment, before anyone sets REOPENED on this bug, remember that
you need to set Firebird as your default browser again before this change will
take effect. Just installing the 2003-11-28 build without setting it as your
default browser will cause the old (incorrect) behaviour to continue.

Comment 29

[Jason Barnabe (np)]

*** Bug 227045 has been marked as a duplicate of this bug. ***

Comment 30

[Simon Paquet [:sipaq]]

*** Bug 227715 has been marked as a duplicate of this bug. ***

Comment 31

[Ali Ebrahim]

*** Bug 232037 has been marked as a duplicate of this bug. ***

Comment 32

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change