Closed
Bug 301917
Opened 19 years ago
Closed 19 years ago
Cursor keys disabled/Caret not moving with keyboard in message compose window
Categories
(SeaMonkey :: MailNews: Message Display, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: KlausRusch, Assigned: Bienvenu)
References
Details
(Keywords: fixed1.7.11, regression, Whiteboard: [fixed1.7.11])
Attachments
(1 file)
2.77 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
asa
:
approval1.7.11+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Since upgrading to Mozilla 1.7.10, cursor keys occasionally stop working in the mail composition window. Cursor up, down, left, right, home, end are all inactive, changing window focus to another application and back to Mozilla usually resolves the problem. Reproducible: Sometimes Steps to Reproduce: 1. Compose new mail/reply to mail 2. Try moving with the cursor keys
Reporter | ||
Updated•19 years ago
|
Version: unspecified → 1.7 Branch
Confirming, seeing this also with 1.7 builds since a short time before the final 1.7.10 release. Didn't find another report. Try to load Mozilla, open Mailnews and open a compose window. Type some characters and several carriage returns (enter) into the body and try to move up with the keyboard (arrow up). Nothing happens. It is later only sporadic. I don't see any JS errors in the console.
Summary: Cursor keys disabled → Cursor keys disabled/Caret not moving with keyboard in message compose window
Updated•19 years ago
|
Flags: blocking1.7.11?
Comment 2•19 years ago
|
||
I've the same problem. CC, bcc and subject lines seem also be affected sometimes. Please set severity a little bit higher - it's really annoying! My OS is win2k.
Same problem, Win XP, however, reproducible always, the change of focus/restart does not help at all, the cursor keys never work. I had to go back to 1.7.8.
Assignee | ||
Comment 4•19 years ago
|
||
yes, this happens to me too - very odd
Updated•19 years ago
|
Flags: blocking1.7.11? → blocking1.7.11+
Comment 5•19 years ago
|
||
Can anyone here pinpoint the day this regressed or at least help us narrow that down?
windows XP, happens on two different machines. Switching back to 1.7.8. Also happens in browser as well is mail composition.
Comment 7•19 years ago
|
||
BTW: It looks like some controller(?) or focus gets lost here, since when this bug occours, the menu items like Paste, Select All, Rewrap, etc. in the Edit menu are grayed out.
Assignee | ||
Comment 8•19 years ago
|
||
What I've found that it's sufficient to do this. bring up new compose window type test<ret> at that point, the arrow keys don't work. Switching focus fixes things, and I haven't been able to get it to break again without shutting down and restarting. Does anyone have this happen to them more than once in a session? Since we cache the compose window, I wonder if this is some sort of initialization problem...this is a bit difficult to debug since hitting a breakpoint in the debugger switches focus :-)
(In reply to comment #7) > BTW: It looks like some controller(?) or focus gets lost here, since when this > bug occours, the menu items like Paste, Select All, Rewrap, etc. in the Edit > menu are grayed out. Aha, I guess Bug 301968 is related.
Assignee | ||
Comment 10•19 years ago
|
||
ah, the cursor keys don't work at all with the first compose window, until focus is lost and regained. Pressing <ret> has nothing to do with it.
Comment 11•19 years ago
|
||
I think this regressed between 2005-07-11-09 and 2005-07-12-09 builds.
Comment 12•19 years ago
|
||
Johnny and David both checked in in that window (and it looks like only them) Johnny, could this be fallout from that last change to bug 296704 ?
Comment 13•19 years ago
|
||
To help confirm, can any others of you who are seeing this problem please try to reproduce with this build? http://mozilla.isc.org/pub/mozilla.org/mozilla/nightly/2005-07-11-09-1.7/mozilla-win32-installer.exe This build seems to be working for me but I was only able to reproduce the problem intermittently.
Assignee | ||
Comment 14•19 years ago
|
||
looks like the img manager changes are somehow responsible - backing them out fixes the problem. I have no idea how that could be, however. I'll do some more sanity checks.
Comment 15•19 years ago
|
||
(In reply to comment #13) [Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.9) Gecko/20050711] (-09 nightly) (W98SE) Confirming that this build did not yet have this bug.
Assignee | ||
Comment 16•19 years ago
|
||
OK, this is not pleasant - the problem seems to have to do with calling GetBaseURI on every context that gets passed into ShouldLoad. It seems to have some unpleasant side effect in some cases. I determined that it's a non image object case, and that if I don't call it on non APP_TYPE_MAIL doc shells, or on non image objects, then the problem goes away. I determined as best I could that it wasn't an error return from ShouldLoad, or a different out aShouldLoad return that was causing the problem, but simply calling that GetBaseURI code (which I didn't change - just moved into its own function). Boris, if you have any suggestion as to what that side effect could be, I could try to fix that side effect, but for now, this fixes the problem.
Comment 17•19 years ago
|
||
Comment on attachment 190627 [details] [diff] [review] possible fix [Checked in: Comment 24] I bet the issue is that calling GetDocument() on a window will create an about:blank document as needed; if this is done as we're trying to load things in the window, I can see how it could make things confusing... This looks like exactly the right fix.
Attachment #190627 -
Flags: superreview+
Attachment #190627 -
Flags: review?(bzbarsky)
Attachment #190627 -
Flags: review+
Updated•19 years ago
|
Attachment #190627 -
Flags: approval1.7.11+
Assignee | ||
Updated•19 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 18•19 years ago
|
||
*** Bug 302350 has been marked as a duplicate of this bug. ***
Comment 19•19 years ago
|
||
Can those of you who were experiencing this bug please get today's branch build from http://mozilla.isc.org/pub/mozilla.org/mozilla/nightly/latest-1.7/ and verify that this issue is indeed fixed? Thanks.
Comment 20•19 years ago
|
||
I tested again with build 2005072706 on WinXP and I can confirm that it now works for me. Thanks!
Comment 21•19 years ago
|
||
Bug 302384 and bug 301827 are possible dupes of this bug and Bug 301968.
Assignee | ||
Comment 22•19 years ago
|
||
*** Bug 301968 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 23•19 years ago
|
||
*** Bug 301827 has been marked as a duplicate of this bug. ***
Comment 24•19 years ago
|
||
Comment on attachment 190627 [details] [diff] [review] possible fix [Checked in: Comment 24] Check in: { 2005-07-26 15:36 bienvenu%nventure.com MOZILLA_1_7_BRANCH }
Attachment #190627 -
Attachment description: possible fix → possible fix
[Checked in: Comment 24]
Comment 25•19 years ago
|
||
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.10) Gecko/20050727] (-08 nightly) (W98SE) V.Fixed.
Status: RESOLVED → VERIFIED
Whiteboard: [fixed1.7.11]
Comment 26•19 years ago
|
||
*** Bug 302318 has been marked as a duplicate of this bug. ***
Comment 27•19 years ago
|
||
*** Bug 302459 has been marked as a duplicate of this bug. ***
Comment 28•19 years ago
|
||
*** Bug 302384 has been marked as a duplicate of this bug. ***
Comment 29•19 years ago
|
||
*** Bug 302641 has been marked as a duplicate of this bug. ***
*** Bug 302777 has been marked as a duplicate of this bug. ***
Comment 31•19 years ago
|
||
Wow, what a mess, I'm glad this was fixed so fast (and also this one: https:// bugzilla.mozilla.org/show_bug.cgi?id=300749 ), these TWO issues made Mail completely unusable! I just reverted to 1.7.8 when I saw that 1.7.11 is out now. I wonder how such TWO bad bugs in the UI could make it through to a release, is there no regression testing before doing a release???
Comment 32•19 years ago
|
||
*** Bug 303139 has been marked as a duplicate of this bug. ***
Comment 33•19 years ago
|
||
*** Bug 301710 has been marked as a duplicate of this bug. ***
Comment 34•19 years ago
|
||
After visiting "Einstellungen" cursor keys work normal
Updated•19 years ago
|
Keywords: fixed1.7.11
You need to log in
before you can comment on or make changes to this bug.
Description
•