[Modern 2.1] global fixes: autocomplete.css to menulist.css

RESOLVED FIXED in seamonkey2.1final

Status

SeaMonkey
Themes
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

({modern})

Trunk
seamonkey2.1final
modern

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
Notes:
autocomplete.css
  Bug 403659 - autocomplete dropdown has shaded bar / is not big enough after 118312
  Bug 400682 - favicons displayed at full size in open location autocomplete and homepage (pref ui) autocomplete
  (Bug 399281 - Transition location bar auto-complete results to a richlistbox widget)

button.css
  Bug 512702 - Fix incorrect <button type="menu"> dropmarker size on Windows
  Bug 620896 - Remove -moz-box-align:center and -moz-box-pack:center from type=menu-button buttons.
  [not needed] Bug 612181 - Clicking edge of popup notification button main action button opens the dropdown instead.

expander.css

findBar.css
  Bug 483378 - findbar-textbox should be a proper textbox rather than faking the appearance on find-field-container.
    [not needed except yellow background colour for initial flash] 
  Bug 481427 - findbar-textbox binding incorrectly assigned in theme files

global.css
  Bug 460934 - tooltip-label class should be globally available.
  Bug 468860 - class=plain should turn off -moz-appearance too.
    [Do we need this?]

groupbox.css
  Bug 483187 - Caption of groupbox isn't correctly vertically aligned.

menulist.css
  Bug 477113 - RTL text-align changes throughout the theme because of bug 299837.
(Assignee)

Comment 1

7 years ago
Created attachment 526503 [details] [diff] [review]
Patch v1.0

> +
> +.autocomplete-treebody::-moz-tree-image(treecolAutoCompleteValue) {
> +  max-width: 16px;
> +  height: 16px;
> +}

Bug 400682 - favicons displayed at full size in open location autocomplete and homepage (pref ui) autocomplete

> button[type="menu-button"] {
> -  -moz-box-align: center;
> -  -moz-box-pack: center;

Bug 620896 - Remove -moz-box-align:center and -moz-box-pack:center from type=menu-button buttons.

> -  border: none !important;
> +  border: none;
>    background: transparent !important;

Some bits from Bug 612181 - Clicking edge of popup notification button main action button opens the dropdown instead.

>  .button-menu-dropmarker,
>  .button-menubutton-dropmarker {
>    margin: 1px;
> -  background-color: transparent !important;
> -  border: none !important;
> -  min-width:9px;
> -  min-height:5px;

> +  background-color: transparent;
> +  border: none;

Some bits from Bug 612181

> +  width: 9px;
> +  height: 5px;

Bug 512702 Fix incorrect <button type="menu"> dropmarker size on Windows

> -.findbar-textbox {
> -  -moz-binding: url("chrome://global/content/bindings/findbar.xml#findbar-textbox");

Bug 481427 - findbar-textbox binding incorrectly assigned in theme files

> +.findbar-textbox[flash="true"] {
> +  background-color: #FFFF00;
> +  color: #000000;

Bug 483378 - findbar-textbox should be a proper textbox rather than faking the appearance on find-field-container.
  [only the bit for yellow initial flash] 

> +++ b/suite/themes/modern/global/global.css
>  
> +.tooltip-label {
> +  margin: 0px;

Bug 460934 - tooltip-label class should be globally available.

> +++ b/suite/themes/modern/global/groupbox.css
> +
> +/* !important is needed to override label in global.css */
> +.caption-text {
> +  margin: 0 2px !important;

Bug 483187 - Caption of groupbox isn't correctly vertically aligned.

==================================================================

re: global.css Do we need Bug 468860 (class=plain should turn off -moz-appearance too)?
Attachment #526503 - Flags: review?(neil)

Comment 2

7 years ago
Comment on attachment 526503 [details] [diff] [review]
Patch v1.0

>-  min-width:9px;
>-  min-height:5px;
>+  width: 9px;
>+  height: 5px;
I don't know why we have a width and height here at all, since the image has a natural width and height (10px square including padding). Overriding that here makes the image disappear!

>diff --git a/suite/themes/modern/global/expander.css b/suite/themes/modern/global/expander.css
Where can I find an expander?

>+  color: #000000;
Nit: unlike Classic, we know the text colour is already black.

>\ No newline at end of file
Nit: fix please

>+/* !important is needed to override label in global.css */
>+.caption-text {
>+  margin: 0 2px !important;
I don't think this affects the vertical alignment of the caption.
Anyway, I think Classic changed its values to match the OS better.

We don't need bug 468860 for supposedly obvious reasons.
(Assignee)

Comment 3

7 years ago
Created attachment 527182 [details] [diff] [review]
Patch v1.1 fix nits

> neil@parkwaycc.co.uk      2011-04-16 15:48:07 PDT
> 
> >-  min-width:9px;
> >-  min-height:5px;
> >+  width: 9px;
> >+  height: 5px;
> I don't know why we have a width and height here at all, since the image has a
> natural width and height (10px square including padding). Overriding that here
> makes the image disappear!
Removed.

> >diff --git a/suite/themes/modern/global/expander.css b/suite/themes/modern/global/expander.css
> Where can I find an expander?

Firefox 1.0 (Options->Advanced) and Thunderbird 1.0
http://mxr.mozilla.org/aviarybranch/search?string=<expander&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=aviarybranch

Removed from patch.

> >+  color: #000000;
> Nit: unlike Classic, we know the text colour is already black.
Removed.

> >\ No newline at end of file
> Nit: fix please
Fixed.

> >+/* !important is needed to override label in global.css */
> >+.caption-text {
> >+  margin: 0 2px !important;
> I don't think this affects the vertical alignment of the caption.
> Anyway, I think Classic changed its values to match the OS better.

Changed this to -moz-margin-start: 2px !important; to align with the contents of the groupbox.

> We don't need bug 468860 for supposedly obvious reasons.
Yes, thanks.
Attachment #526503 - Attachment is obsolete: true
Attachment #526503 - Flags: review?(neil)
Attachment #527182 - Flags: review?(neil)

Comment 4

7 years ago
Comment on attachment 527182 [details] [diff] [review]
Patch v1.1 fix nits

>+
>+/* !important is needed to override label in global.css */
>+.caption-text {
>+  -moz-margin-start: 2px !important;
>+}
This doesn't work in all cases, e.g. Fonts preferences.
r=me with it removed.
Attachment #527182 - Flags: review?(neil) → review+
(Assignee)

Comment 5

7 years ago
Created attachment 527718 [details] [diff] [review]
Patch v1.1a as pushed r=Neil [checkin comment 5]

> neil@parkwaycc.co.uk      2011-04-20 01:46:29 PDT
> 
> Comment on attachment 527182 [details] [diff] [review]
> Patch v1.1 fix nits
> 
> >+
> >+/* !important is needed to override label in global.css */
> >+.caption-text {
> >+  -moz-margin-start: 2px !important;
> >+}
> This doesn't work in all cases, e.g. Fonts preferences.
> r=me with it removed.
Fixed.

Pushed:
http://hg.mozilla.org/comm-central/rev/1cb31f2bbbfc
http://hg.mozilla.org/releases/comm-2.0/rev/4f1d5fc1cb28
Attachment #527182 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1final
You need to log in before you can comment on or make changes to this bug.