Closed Bug 821687 Opened 8 years ago Closed 7 years ago

Status panel should be attached to the content area without overlapping surrounding chrome

Categories

(Firefox :: General, defect)

x86
All
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 26
Tracking Status
firefox25 --- verified
firefox26 --- verified

People

(Reporter: paul, Assigned: dao)

References

(Regression)

Details

(Keywords: addon-compat)

Attachments

(2 files, 2 obsolete files)

We want the statusbar to be above the devtools box. That means moving the statusbar inside the tab. That would imply building one statusbar per tab.
Dao, do you think it's something feasible?
I don't think one status panel per tab this is very reasonable, given the global nature of the XULBrowserWindow infrastructure.
Possible workaround: when the toolbox is present in the current tab, we translate (as is transform:translateY()) the statusbar.
Attached patch patch v0.1 (obsolete) — Splinter Review
Translating the statusbar. This is not the final version and a lot of cases are missed out. But asking for feedback to see if this approach is acceptable.
Assignee: nobody → scrapmachines
Status: NEW → ASSIGNED
Attachment #754223 - Flags: feedback?(dao)
Comment on attachment 754223 [details] [diff] [review]
patch v0.1

I'd rather not have external code mess with the status panel's position. If multiple actors did that, things would quickly get messy, as you assume you're the only one setting a CSS transform on the status panel.
Attachment #754223 - Flags: feedback?(dao) → feedback-
So any suggestions here , anyone ?
See Also: → 885742
See Also: 885742
[this is out of my scope now :) ]
Assignee: scrapmachines → nobody
Status: ASSIGNED → NEW
Attachment #754223 - Attachment is obsolete: true
(In reply to Dão Gottwald [:dao] from comment #5)
> Comment on attachment 754223 [details] [diff] [review]
> patch v0.1
> 
> I'd rather not have external code mess with the status panel's position. If
> multiple actors did that, things would quickly get messy, as you assume
> you're the only one setting a CSS transform on the status panel.

So any idea of what we can do to fix this issue?
Blocks: 890613
No longer blocks: 720186, 809898, 821512
QA Contact: developer.tools
Summary: Statusbar should be inside the tab (inside the notificationbox) → Status panel should be attached to the content area without overlapping chrome elements
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #803704 - Flags: review?(mdeboer)
Summary: Status panel should be attached to the content area without overlapping chrome elements → Status panel should be attached to the content area without overlapping surrounding chrome
Attached patch patchSplinter Review
fixed a nit
Attachment #803704 - Attachment is obsolete: true
Attachment #803704 - Flags: review?(mdeboer)
Attachment #803707 - Flags: review?(mdeboer)
Blocks: 914180
lgtm, I triggered a try build to see if this breaks any tests:

https://tbpl.mozilla.org/?tree=Try&rev=5acd3a1dbb8d

...which includes the backout patches from bug 914180.
Attachment #803707 - Flags: review?(mdeboer) → review+
Would it be a good idea to add a (regression) unit test for this?
https://hg.mozilla.org/integration/fx-team/rev/b47e5a0b7704

I have no idea how a useful test for this might look like...
(In reply to Dão Gottwald [:dao] from comment #13)
> I have no idea how a useful test for this might look like...

No idea either. I guess I just wanted to have it mentioned. ;)
https://hg.mozilla.org/mozilla-central/rev/b47e5a0b7704
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
No longer blocks: 630079
Duplicate of this bug: 630079
Blocks: 630079
Comment on attachment 803707 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 914180
User impact if declined: When the patch in bug 914180 lands on Aurora, the status panel will cover the findbar when it's open. This patch fixes that.
Testing completed (on m-c, etc.): one day on m-c, required for backout.
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none
Attachment #803707 - Flags: approval-mozilla-aurora?
Attachment #803707 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Keywords: verifyme
Depends on: 919030
Attached image Screenshot.png
On: XP 32-bit, Ubuntu 12.10 32-bit and Mac OS X 10.7.5 in 32-bit mode, with latest Aurora (build ID: 20130926004003) and 25 beta 2 (build ID: 20130923194050) I can see the status bar above the developer toolbox, in both scenarios:

1) when reloading a page
2) when hovering an URL from the page

Please see the attached screenshot for details. I'm assuming this is the discussed issue here, right?
Flags: needinfo?(paul)
(In reply to Manuela Muntean [:Manuela] [QA] from comment #19)
> Created attachment 810538 [details]
> Screenshot.png
> 
> On: XP 32-bit, Ubuntu 12.10 32-bit and Mac OS X 10.7.5 in 32-bit mode, with
> latest Aurora (build ID: 20130926004003) and 25 beta 2 (build ID:
> 20130923194050) I can see the status bar above the developer toolbox, in
> both scenarios:
> 
> 1) when reloading a page
> 2) when hovering an URL from the page
> 
> Please see the attached screenshot for details. I'm assuming this is the
> discussed issue here, right?

Indeed. You see the valid behavior (status bar not hovering the tools).
Flags: needinfo?(paul)
Marking this verified, based on comment 19 and comment 20. Thanks Paul!
Status: RESOLVED → VERIFIED
No longer blocks: 817695
Depends on: 1240218
Blocks: 541656
Whiteboard: regression from bug 541656
Depends on: 920454
Duplicate of this bug: 802525
Depends on: 1325880
No longer blocks: 541656
Keywords: verifyme
Regressed by: 541656
Whiteboard: regression from bug 541656
You need to log in before you can comment on or make changes to this bug.