[news filters] implement filter after the fact (make Run Filters on Folder available for newsgroups)

RESOLVED FIXED in Thunderbird 5.0b1

Status

MailNews Core
Filters
--
enhancement
RESOLVED FIXED
15 years ago
6 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: rkent)

Tracking

Trunk
Thunderbird 5.0b1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

[news filters] implement filter after the fact

Comment 1

15 years ago
Using build 2002110604 on Linux, I see the following:

The menuitem Tools -> Run Filters on Selected Folder is available for news.

It seems to do nothing while online (although it seems to talk to the server and
the Filter Log shows some actions).
It runs filters fine while offline - it marks the existing messages properly.
But I only used 'label message' and 'mark as read' actions.

Comment 2

14 years ago
Update, using trunk build 20030523 on winxp, the menu item to Run Filters on
Folder is disabled when a Newsgroup is selected and the Run Now button is not in
the Filter Rules dialog when a Newsgroup is selected.  This is correct at this
time since we haven't implemented Filter After the Fact for News yet. 

Comment 3

14 years ago
*** Bug 180016 has been marked as a duplicate of this bug. ***

Comment 4

14 years ago
*** Bug 197517 has been marked as a duplicate of this bug. ***

Updated

14 years ago
Severity: normal → enhancement

Comment 5

14 years ago
I still see that Problem in 
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5b) Gecko/20030910

I created a filter to label posts of a special sender as "later"
The filter does not work, existing posts of the sender will not be labeled.
There is no button "run now" in my "Message Filter" dialog window for NG-filters
Menu: Tools/Run Filters on folder is ghosted, I can not run filters.

We had this function somewhere 1.3 (?), I am missing it.

Rainer

Updated

14 years ago
Blocks: 16913

Updated

14 years ago
No longer blocks: 16913

Comment 6

14 years ago
might be reasonable to reopen bug 17483 because of regression?

Rainer
Product: MailNews → Core

Comment 7

13 years ago
*** Bug 273925 has been marked as a duplicate of this bug. ***

Updated

11 years ago
Assignee: sspitzer → nobody
OS: Windows 2000 → All
QA Contact: laurel → filters
Hardware: PC → All

Updated

10 years ago
Duplicate of this bug: 366904
News filtering works (here Thunderbird 1.5.0.9), but it's really a pain that you can not apply the filters for news groups folders (e.g. for testing the filter).

Will this change in TB 2.0?

Comment 10

10 years ago
It seems to me the right way to handle this problem would be to add an option "Discard already-read messages at exit" in Tools -> Account Settings -> Server Settings.  If I want to keep a message, I'll copy it to a local mail folder.

Certainly if there is an option to manually delete messages from the cache, the documentation should be written to make clear that this is not the same thing as cancelling a message on the newsgroup.

Updated

10 years ago
Duplicate of this bug: 406209

Updated

9 years ago
Summary: [news filters] implement filter after the fact → [news filters] implement filter after the fact (make Run Filters on Folder available for newsgroups)

Updated

9 years ago
Duplicate of this bug: 410960

Comment 13

9 years ago
(In reply to comment #9)
> News filtering works (here Thunderbird 1.5.0.9), but it's really a pain that
> you can not apply the filters for news groups folders (e.g. for testing the
> filter).
> 
> Will this change in TB 2.0?
> 

Not in TB 2.0! or even 3.0?

Comment 14

9 years ago
(In reply to comment #9)
> News filtering works (here Thunderbird 1.5.0.9), but it's really a pain that
> you can not apply the filters for news groups folders (e.g. for testing the
> filter).
> 
> Will this change in TB 2.0?
> 

Not in TB 2.0! or even 3.0?

Updated

9 years ago
Duplicate of this bug: 418315

Comment 16

9 years ago
Ok. If I see a message I want to kill, I can create a filter. And I still see the message in every single newsgroup I go to. Please. Does not one else get bothered by news spam? Is it really just me?
I'm just as bothered by news spam, but there are far more important things for me to work on than this extension. No developer is obligated to fulfill an enhancement request; if this feature is so important to you, then you have the power to actually write the code to implement the feature yourself.

So please, stop advocating for this feature or demanding that it be written this minute.
Product: Core → MailNews Core
Duplicate of this bug: 390089
Duplicate of this bug: 476323
(Assignee)

Comment 20

8 years ago
I've been running after-the-fact filters on newsgroups in some of my development work, and I am not aware of any issues. I have done a few small changes in folder handling and filtering though that might have made it start to work. Let me investigate this a little, it might not be that difficult to finish what needs doing, and enable the UI. Not making any promises though.
Assignee: nobody → kent
Status: NEW → ASSIGNED
Duplicate of this bug: 510777

Comment 22

8 years ago
I noticed that when viewing newsgroup, the menu item:
Tools->"Run filters on Message" does not run the filters for the current newsgroup.Actually it does nothing.
See the screen shot below:

http://i683.photobucket.com/albums/vv194/ollydbg_cb/Snap2.png
Duplicate of this bug: 524240

Comment 24

7 years ago
Wow, 8 years later, and this bug still hasn't been fixed. There are probably Thunderbird users who weren't born yet when the bug was first reported. Joshua Cranmer is of course correct that nobody can force him to fix a bug that he doesn't want to fix. But if the usenet functionality in Thunderbird isn't going to be actively maintained, maybe Thunderbird should stop claiming to have usenet functionality.
(Assignee)

Comment 25

6 years ago
Created attachment 528496 [details] [diff] [review]
Just enable it
[Checked in: Comment 29 & 36]

After the fact filters just seem to work. As I said, some work I did earlier may have cleaned this up. Joshua am I missing something? I tried all of the searches and actions and they just worked.
Attachment #528496 - Flags: review?(Pidgeot18)
(Assignee)

Updated

6 years ago
Whiteboard: [has patch for review]
First off, I'm sure SeaMonkey would also love to have this feature.

The only other concerns that strike me are potential corner cases in the differences between news and mail handling of code in the filter action backend.

I also want to worry about filter-on-any-header in filter-after-the-fact, but I won't r- this patch just because of that not working properly, especially since I think IMAP has the same problem.

Otherwise, I'm tempted to mark r+, but I want to compile + run with this patch first, so I won't get to it until next Tuesday or so.
Comment on attachment 528496 [details] [diff] [review]
Just enable it
[Checked in: Comment 29 & 36]

Okay, I lied, I got to it earlier than expected. r+, modulo fixing it for SeaMonkey as well. You should also probably file a bug on getting it to work for the case of filter-on-any-header.
Attachment #528496 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 28

6 years ago
Comment on attachment 528496 [details] [diff] [review]
Just enable it
[Checked in: Comment 29 & 36]

I'm not really sure who needs to look at this. Since neither Joshua nor I are module peers of the code that will actually be modified for this, let me give bienvenu a chance to chime in on this.

I will do a separate patch to enable it for SM.
Attachment #528496 - Flags: review?(dbienvenu)

Updated

6 years ago
Attachment #528496 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 29

6 years ago
Comment on attachment 528496 [details] [diff] [review]
Just enable it
[Checked in: Comment 29 & 36]

http://hg.mozilla.org/comm-central/rev/1e34f71069bc
(Assignee)

Updated

6 years ago
Target Milestone: --- → Thunderbird 3.3a4
(Assignee)

Comment 30

6 years ago
Leaving bug open for SeaMonkey patch.
status-seamonkey2.1: --- → ?

Comment 31

6 years ago
(In reply to comment #27)
> Okay, I lied, I got to it earlier than expected. r+, modulo fixing it for
> SeaMonkey as well. You should also probably file a bug on getting it to work
> for the case of filter-on-any-header.

Please cc: me on that bug.

Comment 32

6 years ago
Suite needs to be patched here:
/suite/mailnews/search/FilterListDialog.js
Created attachment 529270 [details] [diff] [review]
SM part [Checkin: comment 35 & 37]

Seeing this seems to take longer, here's the patch, already verified against SM2.1 branch (c-2.0) since trunk it currently FUBAR (patch applies against trunk, too, though). Thanks for the core patch, it's really appreciated! :-)

Mnyromyr, r+moa?
Attachment #529270 - Flags: superreview?(mnyromyr)
Attachment #529270 - Flags: review?(mnyromyr)

Comment 34

6 years ago
Comment on attachment 529270 [details] [diff] [review]
SM part [Checkin: comment 35 & 37]

> Thanks for the core patch, it's really appreciated! :-)

Indeed!

> Mnyromyr, r+moa?

Certainly!
Attachment #529270 - Flags: superreview?(mnyromyr)
Attachment #529270 - Flags: superreview+
Attachment #529270 - Flags: review?(mnyromyr)
Attachment #529270 - Flags: review+
Comment on attachment 529270 [details] [diff] [review]
SM part [Checkin: comment 35 & 37]

http://hg.mozilla.org/comm-central/rev/4af027ba1614
Attachment #529270 - Attachment description: SM part → SM part [Checkin: comment 35]
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [has patch for review]
status-seamonkey2.1: ? → ---
Comment on attachment 528496 [details] [diff] [review]
Just enable it
[Checked in: Comment 29 & 36]

http://hg.mozilla.org/releases/comm-2.0/rev/5a3482f2d9d6
Attachment #528496 - Attachment description: Just enable it → Just enable it [Checked in: Comment 29 & 36]
Comment on attachment 529270 [details] [diff] [review]
SM part [Checkin: comment 35 & 37]

http://hg.mozilla.org/releases/comm-2.0/rev/ddbb9066bafe
Attachment #529270 - Attachment description: SM part [Checkin: comment 35] → SM part [Checkin: comment 35 & 37]
Depends on: 654231
You need to log in before you can comment on or make changes to this bug.