Open Bug 67089 Opened 24 years ago Updated 2 years ago

Add inline as an option when replying to messages - "corporate headers"

Categories

(MailNews Core :: Composition, enhancement, P3)

enhancement

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: scb147, Assigned: mkmelin)

References

Details

Attachments

(1 file, 3 obsolete files)

You should be able to have the option to reply to a message using the Inline
method, instead of just quotes or nothing at all.  The Inline method that is
used when forwarding messages is the format that should be used for the Inline
reply-to format.  

The format for this method would be:
------------------------------------------

<Here is where the replier to the original message
can write his reply.>


-----Original Message-----
From: YourName [mailto:youremail@yourisp.com]
Sent: Monday, January 29, 2001 8:42 AM
To: YourReceipiant 
Subject: xxxxxxxxxxxxxxxxxxx

<Here is where the original message is, without
quotes.>


I believe this enhancement would be similar to how some other email clients work
when replying to messages.
Anyone have comments on this enhancement?
Status: NEW → ASSIGNED
Target Milestone: --- → Future
I would actually prefer this suggested method than the one currently used. Often
I'm curious about more options than are presented, for example what time the email 
was sent.

Or if not that then some way to customize it where you could see attributes like
the time, e.g. "Dick Tracy Wrote (10:37am):" or change it to the email address
itself instead of the, uh, resolved name, e.g. "Dick@Tracy.com Wrote:".
from: Mikko Pervilä <mikko.pervila@advancevpn.com> by email

I have not registered to use BugZilla, but thought I might send you a quick mail
noting that inline quoting has been discussed on the (badly named) forum thread
http://forums.mozillazine.org/viewtopic.php?t=14795&highlight=quoting+inline

Not many replies but I sincerely believe the choice of inline quoting would be
most warmly appreciated by many potential users, like myself.

Keep up the good work.
*** Bug 232555 has been marked as a duplicate of this bug. ***
Product: MailNews → Core
This is a huge problem when using ThunderBird in a enterprise environment.

You must be able to determine the recepients of the original message from the 
reply header.

In my case, it's against the policy of the IT department to modify and/or 
delete the reply headers of the original message. But with ThunderBird the 
headers are not included in the first place. So, I can't use it at work.
(In reply to comment #5)
> In my case, it's against the policy of the IT department to modify and/or 
> delete the reply headers of the original message. But with ThunderBird the 
> headers are not included in the first place. So, I can't use it at work.

Just for information. ThunderBird is not deleting any header information. 
It is keeping all headers properly as real headers in mail itself.

But I agree as suggested by Vladimir there should be options to 
include/exclude inline text headers also.

PS:policy makers of the IT department are idiots. 
If they realy want any kind of integerity 
they should insist on signed mails and ask for
forward as attachemnt instead of reply all.
also the outlook fooling them by doing as they expected
*** Bug 297054 has been marked as a duplicate of this bug. ***
*** Bug 323205 has been marked as a duplicate of this bug. ***
Patch against CVS HEAD on 01/13/2006

Description:
This patch adds support for corporate reply headers. When changing your user.js file as below, and setting mailnews.reply_header_type to 4, the reply header should look like:

From: [author]
Sent: [date]
To: [to]
Cc: [cc]
Subject: [subject]

$ cat user.js
// Change the reply header
// 0 - No Reply-Text
// 1 - "[Author] wrote:"
// 2 - "On [date] [author] wrote:"
// 3 - "[author] said the following on [date]:"
// 4 - "From: [author]
//      Sent: [date]
//      To: [to]
//      Cc: [cc]
//      Subject: [subject]"
// 5 - User-defined reply header. Use the prefs below in conjunction with
// this:
user_pref("mailnews.reply_header_type", 4);

// If you set 5 for the pref above then you may set the following prefs.
user_pref("mailnews.reply_header_authorwrote", "%s said the following");
user_pref("mailnews.reply_header_ondate", "on %s");
user_pref("mailnews.reply_header_separator", " ");
user_pref("mailnews.reply_header_colon", ":");
// The end result will be [authorwrote][separator][ondate][colon]

Caveat: This patch does not resolve recipients (To:) nor cc list (Cc:) to user names, it just dumps what's in the corresponding smtp header field without further processing.
Attached patch Removing debug printout (obsolete) — Splinter Review
Attachment #208434 - Attachment is obsolete: true
Attachment #208435 - Flags: review?(ducarroz)
*** Bug 337863 has been marked as a duplicate of this bug. ***
Hi all !
My father badly needs that feature. It help to make emails more convenient and more professional/business oriented. Please implement the request.
Hi all !

So - is this problem resolved?

If so how I configure it? and what versions of T-bird support it?
(In reply to comment #13)
> Hi all !
> 
> So - is this problem resolved?
> 
> If so how I configure it? and what versions of T-bird support it?
> 

Eric Moret wrote a patch on 2006-01-13  ... but this patch need a review before being apply to the trunk ...
So, now, there is no official version of TB with this new feature ...
If you need this, compile your own version of TB with the patch ...
So, the feature-request was filled in 2001, the code was developed in 2006. Now what we are waiting for? 

Whom should I ask to integrate it into T-bird standard release?
(In reply to comment #15)
> So, the feature-request was filled in 2001, the code was developed in 2006. Now
> what we are waiting for? 
> 
> Whom should I ask to integrate it into T-bird standard release?
> 

If you want this:
http://wiki.mozilla.org/Thunderbird
--> on this wiki you can go to http://wiki.mozilla.org/Talk:Thunderbird:2.0_Product_Planning

--> and ask for this feature ...

There is a problem requesting this feature:
I got to the wiki and got:
====================================================
Thunderbird:2.0 Product Planning
From MozillaWiki

Do not edit this list unless you are on the Thunderbird team. Keep comments to the discussion pages, please. 
====================================================

So basically, if I am not the core-developer, I can't reqquest features?

Again - whom do I ask to include this feature ?
"Keep comments to the discussion pages, please. "
that means "use the discussion page, not the wiki page ..."

and in my previous message i wrote
--> http://wiki.mozilla.org/Talk:Thunderbird:2.0_Product_Planning&action=edit

THIS IS the discussion page ... :-)
You've tried to edit http://wiki.mozilla.org/index.php?title=Thunderbird:2.0_Product_Planning&action=edit
Sorry, but I still don't get it *where* must I add my request.

I have added it here:
http://wiki.mozilla.org/Talk:Thunderbird

But onone replied.... So Thunderbird developers don't look at their own mailing-list?
"Jean-Francois Ducarroz" is who supposed to integrate the patch, but he doesn't respond.... 

Possible solution: open a new bug, until some T-bird developer looks on it.

Other ideas ?
The patch doesn't compile anymore, I can attach one that does.

I'm no reviewer, but I can note about the patch in attachment 208435 [details] [diff] [review]
 - it does not mime decode the to/from/cc from names so I get garbage for non-ascii addresses
 - "Sent:" is used, forward uses "Date:" which I would think is better, the date is not necessarily the time it was sent (think send later...)
 - skip the tabs

I don't think ducarroz is around much anymore... Try bienvenu or mscott when you have fixed those.
Assignee: ducarroz → nobody
Status: ASSIGNED → NEW
QA Contact: esther → composition
Attachment #208435 - Attachment is obsolete: true
Attachment #208435 - Flags: review?(ducarroz)
*** Bug 337863 has been marked as a duplicate of this bug. ***
So how the integration is going ?
(In reply to comment #24)
> So how the integration is going ?

A temp soln. is add following to your prefs.js 

  user_pref("mailnews.reply_header_authorwrote", 
            "-----Original Message-----\nFrom: %s");
  user_pref("mailnews.reply_header_colon", "");
  user_pref("mailnews.reply_header_ondate", "Sent: %s");
  user_pref("mailnews.reply_header_separator", "\n");
  user_pref("mailnews.reply_header_type", 3);


above prefs.js is a temp soln. for bug 67089  
Scott MacGregor/David Bienvenu
Please review and apply attachment 239780 [details] [diff] [review]

PS: Please advice if this is not the right way to ask review.
Attachment #239780 - Flags: review?
Comment on attachment 239780 [details] [diff] [review]
Eric Moret's patch, updated to current trunk 

Biju mailed asking how to request review.  It's hard to explain, at least for me.  Note the email address I'm adding here.

/be
Attachment #239780 - Flags: review? → review?(mscott)
that patch appears to have tabs in it - can you attach one with two space indent instead of tabs?

In general, I know this is an oft-requested feature, and I'm interested in getting it in. 
Product: Core → MailNews Core
Bryan cc: for UI.
Wanted enough for TB3, per comment 28?

magnus or Biju, can you fix up the tabs, update patch to apply if needed, and rerequest review?
Flags: wanted-thunderbird3?
Whiteboard: [patchlove]
Comment on attachment 239780 [details] [diff] [review]
Eric Moret's patch, updated to current trunk 

canceling mscott review
Attachment #239780 - Flags: review?(mscott)
Taking.
Assignee: nobody → mkmelin+mozilla
More hidden prefs?  But I'm happy it doesn't add a menu option :)  We need to figure a better system for these kinds of changes.
I hope to get to this soonish.
Flags: wanted-thunderbird3? → wanted-thunderbird3+
Priority: -- → P3
Target Milestone: Future → Thunderbird 3.0b1
Just wanted to make a note, you know how I love to ask for the moon, in this bug.  The way forward, as I see it, on formatting options like this is to be able to change the formatting in the composer window instead of choosing the format before.

I understand there will be difficulties related to this method as the user may have mixed their reply in with the message already.  However I think the choice is a lot easier for people because it's more visible when you hit reply and see that the formatting is incorrect.  With the current 'choose before replying system' a user would have to close the incorrectly formatted reply and open a new one with the correct formatting.
Target Milestone: Thunderbird 3.0b1 → Thunderbird 3.0b2
Comment on attachment 239780 [details] [diff] [review]
Eric Moret's patch, updated to current trunk 

Magnus, I'm guessing this patch is obsolete, I can't find any other subdirectories under mailnews/compose/resources/ besides content/
The current method is to use user.js for mailnews.reply_header_type 3 for the following variables:
user_pref("mailnews.reply_header_ondate", "   Sent: %s \n");
user_pref("mailnews.reply_header_authorwrote", "   From: %s \n");

However, the desired Reply Header is looking for three variables not published:
"Subject:", "To:" & "CC:"

   Sent: 09/09/2003 09:30
   From: John Doe
Subject: _not available_  <- Don't have the correct Mozilla field
     To: _not available_  <- Don't have this Mozilla field
     cc: _not available>  <- Don't have this Mozilla field

I presume that these variables are available as they show up by default in the "Forward Mail" mail headers. I've (unsuccesfully) tried user.js' mailnews.reply_header_type 4.

Will the variables for Subject, To & cc be published?
Status: NEW → ASSIGNED
Summary: Add inline as an option when replying to messages → Add inline as an option when replying to messages - "corporate headers"
Whiteboard: [patchlove]
Target Milestone: Thunderbird 3.0b2 → ---
Attached patch proposed fixSplinter Review
Let's get this in. Uses the same headers as forward (except for those I don't really think apply, or are useful)
Attachment #8339517 - Flags: review?(mbanner)
Still something to work out with the tests for this one - https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=9c7ae05abded 
At least some of the errors seem "real", but for linux it's all working :/ Strange as i don't see how any of this would be platform dependent.
Comment on attachment 8339517 [details] [diff] [review]
proposed fix

Review of attachment 8339517 [details] [diff] [review]:
-----------------------------------------------------------------

This looks generally reasonable, though currently it is bitrotted so I can't test it out.

Re the test failures, I wonder if you're hitting Linux versus non-Linux line endings or something like that.

::: mail/locales/en-US/chrome/messenger/messengercompose/composeMsgs.properties
@@ +316,5 @@
>  ## reply header in composeMsg
>  ## user specified 
>  mailnews.reply_header_originalmessage=-------- Original Message --------
>  
> +## Strings used in the corporate reply headers table (mailnews.reply_header_type = 4)

Should we re-use existing strings that we use for forward? I'm not sure there's likely to be a need for separate ones here.

::: mailnews/compose/public/nsIMsgCompose.idl
@@ +247,5 @@
>                                                in nsStringRef aBuf, 
>                                                in nsStringRef aSignature,
>                                                in boolean aQuoted,
> +                                              in boolean aHTMLEditor,
> +                                              in boolean aPrefixIsHTML);

Please add documentation for this function, in particular the various parameters and what prefix is used for.
Attachment #8339517 - Flags: review?(mbanner)
See Also: → 595696
See Also: → 107884

Hi, is there any timeline to resolve this?

(In reply to cnmicha from comment #44)

Hi, is there any timeline to resolve this?

Not at this time. Note the priority field = P3. The definition of P3 is "Backlog" per https://firefox-source-docs.mozilla.org/bug-mgmt/guides/priority.html which means there are no plans at this time.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.