Last Comment Bug 792793 - Remove growl support from comm-central
: Remove growl support from comm-central
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: OS Integration (show other bugs)
: Trunk
: x86 Mac OS X
-- blocker (vote)
: Thunderbird 19.0
Assigned To: Florian Quèze [:florian] [:flo] (PTO until February 27)
:
:
Mentors:
Depends on: 806254
Blocks: 461144 476215 479034 508270 510687 515071 519053 519792 531244 538601 540956 570398 675583 741087 777409 852461
  Show dependency treegraph
 
Reported: 2012-09-20 04:09 PDT by Florian Quèze [:florian] [:flo] (PTO until February 27)
Modified: 2013-04-10 00:32 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (7.50 KB, patch)
2012-09-20 04:09 PDT, Florian Quèze [:florian] [:flo] (PTO until February 27)
irving: review+
Details | Diff | Splinter Review

Description User image Florian Quèze [:florian] [:flo] (PTO until February 27) 2012-09-20 04:09:53 PDT
Created attachment 662957 [details] [diff] [review]
Patch

Bug 777409 removed growl support, and the comm-central tree is currently busted:
mailnews/base/src/nsMessengerOSXIntegration.mm:40:10: fatal error: 'nsINotificationsList.h' file not found
make[8]: *** [nsMessengerOSXIntegration.o] Error 1

The attached patch removes Growl specific code from mailnews, but keeps the call to nsIAlertsService, as that will use the new notification center on 10.8.
Comment 1 User image Florian Quèze [:florian] [:flo] (PTO until February 27) 2012-09-20 07:20:22 PDT
Comment on attachment 662957 [details] [diff] [review]
Patch

Requesting review from a few people who are currently online. Whoever gets to it first can do it :).

The try server build is green: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=ddd216b95ff2
Comment 2 User image Mike Conley (:mconley) 2012-09-20 07:20:52 PDT
Comment on attachment 662957 [details] [diff] [review]
Patch

Removing r? because Irving is awesome and said he'd handle this.
Comment 3 User image :Irving Reid (No longer working on Firefox) 2012-09-20 08:00:38 PDT
Comment on attachment 662957 [details] [diff] [review]
Patch

Review of attachment 662957 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Comment 4 User image Florian Quèze [:florian] [:flo] (PTO until February 27) 2012-09-20 08:24:59 PDT
https://hg.mozilla.org/comm-central/rev/30465284129e
Comment 5 User image Mark Banner (:standard8) 2012-11-19 04:09:00 PST
Although this landed in TB 18, it was undone by bug 806254, updating flags.

Note You need to log in before you can comment on or make changes to this bug.