792793 - Remove growl support from comm-central

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Florian Quèze [:florian]]

Attachment: Patch

Bug 777409 removed growl support, and the comm-central tree is currently busted:
mailnews/base/src/nsMessengerOSXIntegration.mm:40:10: fatal error: 'nsINotificationsList.h' file not found
make[8]: *** [nsMessengerOSXIntegration.o] Error 1

The attached patch removes Growl specific code from mailnews, but keeps the call to nsIAlertsService, as that will use the new notification center on 10.8.

Comment 1

[Florian Quèze [:florian]]

Comment on attachment 662957 [details] [diff] [review]
Patch

Requesting review from a few people who are currently online. Whoever gets to it first can do it :).

The try server build is green: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=ddd216b95ff2

Comment 2

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Comment on attachment 662957 [details] [diff] [review]
Patch

Removing r? because Irving is awesome and said he'd handle this.

Comment 3

[:Irving Reid (No longer working on Firefox)]

Comment on attachment 662957 [details] [diff] [review]
Patch

Review of attachment 662957 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 4

[Florian Quèze [:florian]]

https://hg.mozilla.org/comm-central/rev/30465284129e

Comment 5

[Mark Banner (:standard8)]

Although this landed in TB 18, it was undone by bug 806254, updating flags.