Closed Bug 792793 Opened 7 years ago Closed 7 years ago

Remove growl support from comm-central

Categories

(Thunderbird :: OS Integration, defect, blocker)

x86
macOS
defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 19.0

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Bug 777409 removed growl support, and the comm-central tree is currently busted:
mailnews/base/src/nsMessengerOSXIntegration.mm:40:10: fatal error: 'nsINotificationsList.h' file not found
make[8]: *** [nsMessengerOSXIntegration.o] Error 1

The attached patch removes Growl specific code from mailnews, but keeps the call to nsIAlertsService, as that will use the new notification center on 10.8.
Keywords: relnote
Comment on attachment 662957 [details] [diff] [review]
Patch

Requesting review from a few people who are currently online. Whoever gets to it first can do it :).

The try server build is green: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=ddd216b95ff2
Attachment #662957 - Flags: review?(mconley)
Attachment #662957 - Flags: review?(irving)
Comment on attachment 662957 [details] [diff] [review]
Patch

Removing r? because Irving is awesome and said he'd handle this.
Attachment #662957 - Flags: review?(mconley)
Comment on attachment 662957 [details] [diff] [review]
Patch

Review of attachment 662957 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #662957 - Flags: review?(irving) → review+
https://hg.mozilla.org/comm-central/rev/30465284129e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
Whiteboard: [relnote = from TB 18]
Blocks: 519053
Blocks: 519792
Blocks: 531244
Blocks: 538601
Blocks: 540956
Blocks: 515071
Blocks: 479034
Blocks: 510687
Blocks: 675583
Blocks: 476215
Blocks: 461144
Blocks: 741087
Blocks: 508270
Blocks: 570398
Depends on: 806254
Although this landed in TB 18, it was undone by bug 806254, updating flags.
Whiteboard: [relnote = from TB 18] → [relnote = from TB 19]
Target Milestone: Thunderbird 18.0 → Thunderbird 19.0
Blocks: 852461
Keywords: relnote
Whiteboard: [relnote = from TB 19]
You need to log in before you can comment on or make changes to this bug.