Open Bug 63798 Opened 19 years ago Updated 3 years ago

login errors bring up save-as dialog

Categories

(Firefox :: File Handling, defect)

defect
Not set

Tracking

()

People

(Reporter: bugzilla, Unassigned)

References

()

Details

(Keywords: helpwanted)

if you go to:
ftp://mp3:mp3@24.64.9.57/mp3/techno/Earthbound%20-%20One%20Nation%20-%20Trance%20Nation%20(extended%20version).mp3
you will be presented with a save as dialog, which is wrong, since you're not
downloading anything according to the FTP log:
------------------------
1128[119f10e8]: 11d2dac8 Writing "RETR /mp3/techno/Earthbound - One Nation -
Trance Nation (extended version).mp3"
1128[119f10e8]: SUCCEEDED
0[343fe8]: nsFTPChannel::GetContentType() returned audio/mpeg
1128[119f10e8]: 11d2dac8 Process() - READ_BUF - read "550 Sorry, insufficient
credit for download - upload first." (61 bytes)
1128[119f10e8]: 11d2dac8 Process() - ERROR
------------------------

USing build 20001226
Blocks: 62352
Summary: Save as dialog incorrectly shown → 550 - Not handling Credit errors
nice to have.
Keywords: helpwanted
Target Milestone: --- → Future
reassigning to bbaetz@cs.mcgill.ca.
Assignee: dougt → bbaetz
Errors shouldn't give us a save-as dialog...

->0.9.6
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla0.9.6
*** Bug 99049 has been marked as a duplicate of this bug. ***
*** Bug 101039 has been marked as a duplicate of this bug. ***
changing the url, since the previous one doesn't work for me.

I don't see this on linux. What OS's are people seeing this on?
Summary: 550 - Not handling Credit errors → login errors bring up save-as dialog
Seeing this on win32.  The "save as" dialog comes up after a "too many users"
dialog.
So this is win32 only (although it may happen on mac too, I guess) The helper
app code for that may not be checking error codes.

-> xpapps, and law, who I believe owns this code
Assignee: bbaetz → law
Status: ASSIGNED → NEW
Component: Networking: FTP → XP Apps
OS: All → Windows ME
Hardware: All → PC
wfm on macos build id: 2001091804, first the save dialog appears letting me to
choose a location for download before the error is show.
*** Bug 103756 has been marked as a duplicate of this bug. ***
spam: over to File Handling.
Component: XP Apps → File Handling
QA Contact: tever → sairuh
*** Bug 104063 has been marked as a duplicate of this bug. ***
*** Bug 104343 has been marked as a duplicate of this bug. ***
*** Bug 104582 has been marked as a duplicate of this bug. ***
-> all/all - I can reproduce this now. Not sure why I couldn't, before.
OS: Windows ME → All
Hardware: PC → All
I am not usually able to reproduce this; I get an error loading the page
referred to in the original bug description.  Doesn't work in IE, either
("Cannot find server or DNS error").

One time I did seem to get through, and I got an assertion here:

NTDLL! 77f9f9df()
nsDebug::Assertion(const char * 0x03e55978, const char * 0x03e55970, const char
* 0x03e55934, int 0x000001f9) line 290 + 13 bytes
nsFTPChannel::SetNotificationCallbacks(nsFTPChannel * const 0x0368c9a0,
nsIInterfaceRequestor * 0x0363d708) line 505 + 38 bytes
nsExternalAppHandler::RetargetLoadNotifications(nsIRequest * 0x0368c9a0) line 798
nsExternalAppHandler::OnStartRequest(nsExternalAppHandler * const 0x00af20a0,
nsIRequest * 0x0368c9a0, nsISupports * 0x00000000) line 931
nsDocumentOpenInfo::OnStartRequest(nsDocumentOpenInfo * const 0x0368cf78,
nsIRequest * 0x0368c9a0, nsISupports * 0x00000000) line 243 + 34 bytes
nsFTPChannel::OnStartRequest(nsFTPChannel * const 0x0368c9b0, nsIRequest *
0x0368c9a0, nsISupports * 0x00000000) line 633 + 45 bytes
nsOnStartRequestEvent0::HandleEvent(nsOnStartRequestEvent0 * const 0x03690560)
line 225 + 26 bytes
nsStreamListenerEvent0::HandlePLEvent(PLEvent * 0x03690570) line 113 + 12 bytes
PL_HandleEvent(PLEvent * 0x03690570) line 590 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x00d18d18) line 520 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x00a80422, unsigned int 0x0000c0c4, unsigned int
0x00000000, long 0x00d18d18) line 1071 + 9 bytes
USER32! 77e13eb0()
USER32! 77e1401a()
USER32! 77e192da()
nsAppShellService::Run(nsAppShellService * const 0x00d24a50) line 303
main1(int 0x00000001, char * * 0x00352860, nsISupports * 0x00000000) line 1304 +
32 bytes
main(int 0x00000001, char * * 0x00352860) line 1630 + 37 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77e87903()
The assertion is about not having an nsIPrompt; I'm not sure what that's about,
but maybe it's due to the ftp channel wanting to put up a login dialog?

If I ignore the assertion, then I get the downloading dialog.

->mscott
If we can't reproduce this more readily, it's going to be tough.  But
regardless, the problem seems to be in the uriloader.
Assignee: law → mscott
Resetting target milestone; Scott can set it however he sees fit.
Target Milestone: mozilla0.9.6 → ---
*** Bug 109911 has been marked as a duplicate of this bug. ***
*** Bug 115923 has been marked as a duplicate of this bug. ***
*** Bug 127195 has been marked as a duplicate of this bug. ***
*** Bug 125535 has been marked as a duplicate of this bug. ***
*** Bug 129636 has been marked as a duplicate of this bug. ***
Bug 129636 has a trivial way to reproduce:

1)  Start an FTP connection
2)  Hit the stop button or "esc" before a helper app dialog comes up (this
    should be easy -- we currently take many seconds to bring that dialog up)

You will see a helper app dialog pop up as soon as you stop the transfer, which
seems wrong (one would expect the connection to just get cancelled).
*** Bug 132709 has been marked as a duplicate of this bug. ***
*** Bug 133252 has been marked as a duplicate of this bug. ***
*** Bug 134411 has been marked as a duplicate of this bug. ***
duplicates are still coming in, so is this a fix-in-next-release issue?
*** Bug 173280 has been marked as a duplicate of this bug. ***
QA Contact: sairuh → petersen
Assignee: mscott → nobody
QA Contact: chrispetersen → file-handling
Product: Core → Firefox
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.