119879 - dropped bookmarks are inserted in incorrect positions

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[Jeremy M. Dolan]

New profile. Click the 'latest builds' in the PT. bookmark it. Open bookmark
manager. Now you've got:

PTF...
----------
Mozilla Proj...
----------
Index of....

Drag 'Index of' between Mozilla proj and the seperator above it.

### Should have ###

PTF
---------
Index of
Mozilla Proj
---------

### Actually have ###

PTF
Index of
---------
Mozilla Proj
---------

100% reproducable, been around a while, and occurs in lots more annoying ways
then this test case. This might not even be the main problem I see during normal
BM Manager use, but let's fix it quick so I can find out, and try to find any
other testcases for all the DnD issues I'm seeing.

Comment 1

[Chris Lyon]

I think this issue is covered in bug 114606.

Comment 2

[[not reading bugmail]]

*** This bug has been marked as a duplicate of 114606 ***

Comment 3

[[not reading bugmail]]

this is not dupe, sorry, but its about seperators, not the actually moving the
bookmarks.

Comment 4

[[not reading bugmail]]

Jeremy,

I still think that D&D with seperator bars maybe the problem but the change as
noted in this bug I duped it with probably also affects this.  as seem the
change to outliner indexing landed after you filed this.. see again for the
outliner changes bug 119504

anyone,

please feel free to reclose/dupe this to your liking.

Comment 5

[[not reading bugmail]]

Jeremy could you try this again.. in a new build.  Do we still have an issue
with this, this maybe now a dupe of a dependency that exists on bug 114606.  Thanks.

Comment 6

[Andreas Kunz]

Being annoyed by Bookmarks always appearing where I didn't expect them after
drag-and-drop (in Personal toolbar and in "Manage Bookmarks" - mostly they
appear one line above from where I placed them - this is one of my most hated
bugs nowadays) I looked around in bugzilla - and found a real jungle (including
this bug here) of open bugs describing the same:

bug 114256 (bookmark gets into wrong folder after dnd) although related, this
particular aspect is fixed now, but at least one of the dups is more general and
not adressed yet (bug 114878).

bug 114606 (bookmark goes to position above) describes exactly what I see and
hate, but in the meanwhile this bug has been somewhat changed into a tracking
bug and now also adresses other bugs related to bookmark d'n'd. (however,
component is not changed to "Tracking")
Many bugs that also describe the exact behaviour are duped to this one (I'll
list them later) because of its desription, but now nobody cares anymore about
the described problem because this one is now considered a tracking bug by some
people...

bug 119879 (bookmark appears one line above after dnd) is 100% what I see and hate.

bug 127437 (wrong position after dnd in personal toolbar) is about the same
problem just at another place (still mostly off-by-one after dragging bookmark).
Has *lots* of duplicates.

bug 137119 (bookmark positioned one line too high after dragging) is about
bookmark manager again, still the same problem. Was duped against bug 114606
already (same summary) but later reopened (bug 114606 is supposed to be tracking).

bug 139471 is finally about general dnd cleanup and is also supposed to fix this
particular issue I'm talking about. Very recently worked on, but now
unfortunately removed from RC2 list.


So it looks like (almost!) all of these six open bugs are duplicates of one
another, but correct duping and resolving was prevented by halfheartedly
changing bug 114606 into a tracking bug.
In addition the underlying bug I speak about (bookmark d'n'd results in wrong
position) was reported in many other bugs which are now duped to one of the six
bugs above: bug 115420, bug 116076, bug 117134, bug 120245, bug 122599, bug
130702, bug 137119, bug 130453, bug 130836, bug 132390, bug 134656, bug 137117,
bug 140071, bug 140342 and bug 140971 are the ones I found.


As you can see from the dup count or simply from imagining a browser where
bookmarks do not materialize where they are dropped, this is a quite serious
problem (and in my humble opinion should not go into 1.0). 

I think it would be a rewarding task for someone with the appropriate
permissions to clean up this jungle a bit. Maybe by clearly (and correctly)
labeling a general tracking bug and a separate one for the one particular d'n'd
problem I'm talking about (and duping the others against it).
This cleanup would get us rid of several ASSIGNED and NEW bugs and prepare the
way for fixing this one annoying d'n'd issue. 
Bug 139471 unfortunately was taken off the RC2 list (bug 138000) by Asa because
of its complexity. A simple "fix this one bug" wouldn't have been, I think.

Comment 7

[Shark Daddy (Jonathan L.)]

*** Bug 145570 has been marked as a duplicate of this bug. ***

Comment 8

[Pierre Chanial]

fixed on trunk by the checkin of bug 137119

Comment 9

[Pierre Chanial]

*** Bug 148946 has been marked as a duplicate of this bug. ***

Comment 10

[Michael Lefevre]

*** Bug 143666 has been marked as a duplicate of this bug. ***