Closed Bug 189598 Opened 22 years ago Closed 22 years ago

application/octet-stream handlers should not be remembered automatically

Categories

(Core Graveyard :: File Handling, defect)

Product:
Core Graveyard
Component:
File Handling
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: bzbarsky, Assigned: pkwarren)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

Second attempt
2.08 KB, patch
bzbarsky
: review+
jag+mozilla
: superreview+
Details | Diff | Splinter Review
The problem is that we do not want to be remembering any "application/octet-stream to extension" or "application/octet-stream to helper" associations. If the user explicitly enters such in the helper app prefs, that is fine. But otherwise, we should _not_ remember these and the "Always show this dialog" box should be checked and _disabled_ to indicate what's going on. pkw, interested in this one?
I'll take a look at this.
Attached patch First attempt (obsolete) — — Splinter Review
If the mime type is listed as application/octet-stream then disable the checkbox and set the alwaysAsk checkbox to true.
Comment on attachment 112094 [details] [diff] [review] First attempt You also want to make sure not to persist the user's decision to prefs...
Attachment #112094 - Flags: review-
Attached patch Second attempt — — Splinter Review
Don't update helper application preferences for application/octet-stream.
Attachment #112094 - Attachment is obsolete: true
Attachment #112100 - Flags: review?(bzbarsky)
To pkw.
Assignee: bzbarsky → pkw
Comment on attachment 112100 [details] [diff] [review] Second attempt looks good. :)
Attachment #112100 - Flags: superreview?(jaggernaut)
Attachment #112100 - Flags: review?(bzbarsky)
Attachment #112100 - Flags: review+
Comment on attachment 112100 [details] [diff] [review] Second attempt sr=jag
Attachment #112100 - Flags: superreview?(jaggernaut) → superreview+
Blocks: 160533
Fixed with last night's checkin.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Looking for a test case to help me verify this fix. Any ideas ?
Added testcase to URL field. ;)
URL: data:application/octet-stream,text
Ok, this works fine on the 2003-01-23-07 OS Mach-0 build with the test case provided. However, I'm having a problem opening this test case under the win32 (2003-01-24-08) build. I basically get a download error that states the source could not be read. This could be related to http://bugzilla.mozilla.org/show_bug.cgi?id=190465.
Almost certainly. Marking dependent so this can be verified once that's fixed.
Depends on: 190465
Verified in the Win32 2003-01-25-08 trunk build under Windows XP.
Status: RESOLVED → VERIFIED
*** Bug 191647 has been marked as a duplicate of this bug. ***
*** Bug 192138 has been marked as a duplicate of this bug. ***
*** Bug 192580 has been marked as a duplicate of this bug. ***
*** Bug 150736 has been marked as a duplicate of this bug. ***
*** Bug 192811 has been marked as a duplicate of this bug. ***
*** Bug 193781 has been marked as a duplicate of this bug. ***
*** Bug 194437 has been marked as a duplicate of this bug. ***
I have a quick question. If this bug has been fixed, why did I encounter the problem in bug report #194437 (http://bugzilla.mozilla.org/show_bug.cgi?id=194437) using this build: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.3b) Gecko/20030218 It looks like this was fixed back in January. Peace.....
Because at some point you used a build from before January. This bug was about us creating a bogus helper app entry; wwith this patch in, we don't create new such entries, but if you have one it sticks around till you delete it.
Gotcha.... I've deleted the "problematic" entry and all is well now. Thanks! Peace.....
*** Bug 195726 has been marked as a duplicate of this bug. ***
*** Bug 196528 has been marked as a duplicate of this bug. ***
*** Bug 193502 has been marked as a duplicate of this bug. ***
*** Bug 197192 has been marked as a duplicate of this bug. ***
*** Bug 197319 has been marked as a duplicate of this bug. ***
*** Bug 193502 has been marked as a duplicate of this bug. ***
*** Bug 197809 has been marked as a duplicate of this bug. ***
*** Bug 191328 has been marked as a duplicate of this bug. ***
*** Bug 200221 has been marked as a duplicate of this bug. ***
*** Bug 200477 has been marked as a duplicate of this bug. ***
*** Bug 200880 has been marked as a duplicate of this bug. ***
*** Bug 201948 has been marked as a duplicate of this bug. ***
What Mozilla release was this fixed in? Is that info displayed on this Bugzilla form anywhere? Peace...
*** Bug 202118 has been marked as a duplicate of this bug. ***
*** Bug 205279 has been marked as a duplicate of this bug. ***
*** Bug 205381 has been marked as a duplicate of this bug. ***
*** Bug 205678 has been marked as a duplicate of this bug. ***
*** Bug 204666 has been marked as a duplicate of this bug. ***
*** Bug 208751 has been marked as a duplicate of this bug. ***
*** Bug 212234 has been marked as a duplicate of this bug. ***
*** Bug 212443 has been marked as a duplicate of this bug. ***
*** Bug 219098 has been marked as a duplicate of this bug. ***
*** Bug 221771 has been marked as a duplicate of this bug. ***
*** Bug 210958 has been marked as a duplicate of this bug. ***
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: