Closed Bug 114377 Opened 24 years ago Closed 24 years ago

Crash right clicking on imagemap (at amazon.com, etc.) - Trunk, M097 [@ XULPopupListenerImpl::FireFocusOnTargetContent]

Categories

(Core :: XUL, defect, P1)

Product:
Core
Component:
XUL
Platform:
x86
Windows 2000
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.8

People

(Reporter: scottputterman, Assigned: dbaron)

References

(
URL
)

Details

(5 keywords)

Crash Data

Attachments

(3 files)

Image used for the upcoming testcase
1.15 KB, image/gif
Details
Testcase that crashes Mozilla when right-clicking on the bar
349 bytes, text/html
Details
null-check fix
1.24 KB, patch
Details | Diff | Splinter Review
Using 12/8 build on Win 2000. Was on amazon.com. I was in the Books section. I right clicked on the Bestsellers tab to see if I could open it in a new window. I crashed immediately. My talkback id is 270559 The top of the stack is: XULPopupListenerImpl::FireFocusOnTargetContent [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULPopupListener.cpp, line 331] XULPopupListenerImpl::PreLaunchPopup [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULPopupListener.cpp, line 305] XULPopupListenerImpl::ContextMenu [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULPopupListener.cpp, line 206] nsEventListenerManager::HandleEvent [d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, line 1500] nsXULElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 3403] nsXULElement::HandleChromeEvent [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 4610]
Keywords: crash, nsbeta1
OS: Linux → Windows 2000
wfm, Linux 2001120906
confirming using build 2001120808 on Win2k. Another Talkback ID (if needed): TB279558G.
Severity: normal → critical
This is a topcrasher with recent MozillaTrunk builds on Win2k, XP and NT. Here's the latest from Talkback: XULPopupListenerImpl::FireFocusOnTargetContent 48 BBID range: 126997 - 310255 Min/Max Seconds since last crash: 25 - 206102 Min/Max Runtime: 563 - 206102 Crash data range: 2001-12-06 to 2001-12-10 Build ID range: 2001120606 to 2001121010 Keyword List : Stack Trace: XULPopupListenerImpl::FireFocusOnTargetContent [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULPopupListener.cpp line 331] XULPopupListenerImpl::PreLaunchPopup [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULPopupListener.cpp line 305] XULPopupListenerImpl::ContextMenu [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULPopupListener.cpp line 206] nsEventListenerManager::HandleEvent [d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp line 1500] nsXULElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp line 3403] nsXULElement::HandleChromeEvent [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp line 4610] GlobalWindowImpl::HandleDOMEvent [d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp line 659] nsDocument::HandleDOMEvent [d:\builds\seamonkey\mozilla\content\base\src\nsDocument.cpp line 3069] nsGenericElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\content\base\src\nsGenericElement.cpp line 1900] nsGenericElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\content\base\src\nsGenericElement.cpp line 1900] nsGenericElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\content\base\src\nsGenericElement.cpp line 1900] nsGenericElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\content\base\src\nsGenericElement.cpp line 1900] nsGenericHTMLElement::HandleDOMEventForAnchors [d:\builds\seamonkey\mozilla\content\html\content\src\nsGenericHTMLElement.cpp line 1325] nsHTMLAnchorElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\content\html\content\src\nsHTMLAnchorElement.cpp line 420] PresShell::HandleEventInternal [d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp line 5856] PresShell::HandleEvent [d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp line 5776] nsView::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp line 387] nsView::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp line 344] nsView::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp line 344] nsViewManager::DispatchEvent [d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp line 1920] HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp line 83] nsWindow::DispatchEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 850] nsWindow::DispatchWindowEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 867] nsWindow::DispatchMouseEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 4436] ChildWindow::DispatchMouseEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 4686] nsWindow::ProcessMessage [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 3371] nsWindow::WindowProc [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 1115] KERNEL32.DLL + 0x363b (0xbff7363b) KERNEL32.DLL + 0x24407 (0xbff94407) Source File : http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/xul/content/src/nsXULPopupListener.cpp line : 331 (301565) URL: http://muddasheep.strikenet.at/index2.html (301565) Comments: right click on the news link (301086) URL: alamo.com (301086) Comments: Right clicked on "locations" link. (301052) URL: alamo.com (301052) Comments: Right clicked on the (green) "locations" link/graphic. (288769) Comments: right clicked a link on mapquest (279558) URL: http://www.amazon.com/exec/obidos/tg/browse/-/283155/ref=gw_br_bo/002-1480029-5821620 (274078) Comments: www.mxstream.nl just browsing... (270559) Comments: right clicking on Amazon.com (244138) URL: http://process-of-elimination.net (230876) URL: ebay.com (230876) Comments: right-clicked on "my ebay" link. Boom. Computer appears to be unstable ignore unless there are confirming stacks. (209108) URL: http://www.geoshell.com/ (209108) Comments: right click on picture in composer (203016) URL: http://www.hancom.com/ (203016) Comments: First page is an English page.1) click "Korean" link at upper menu2) a new window is created3) close Korean page window4) clicked mouse right button at the same link above (185583) Comments: Right clicked on a link that said Chat FAQ above a picture of Ireland.
Keywords: topcrash
Summary: Crash right clicking on amazon.com at XULPopupListenerImpl::FireFocusOnTargetContent → Crash right clicking on amazon.com [@ XULPopupListenerImpl::FireFocusOnTargetContent]
*** Bug 114762 has been marked as a duplicate of this bug. ***
From dupe bug 114762: TB354880X is an additional Talkback ID, if that helps.
*** Bug 115051 has been marked as a duplicate of this bug. ***
I made (at least that's one way) a reproducible crashing testcase with an image from http://www.securityfocus.com/ I also succeeded in producing a testcase with some our internal imagemap (company Intranet). The bug really seems to deal with client-side imagemap as I do not crash with server-side imagemaps.
Keywords: testcase
Will it be possible to make a fix for 0.9.7 or is it already too late ?
Keywords: regression
*** Bug 115251 has been marked as a duplicate of this bug. ***
Olivier: I don't see a patch in this bug yet and we just branched for Mozilla 0.9.7, so I don't think any fix is gonna make it in. This is definitely still a topcrasher on the MozillaTrunk, are we going to try to get this fixed for Mozilla 0.9.8? The target milestone still needs to be set.
*** Bug 115540 has been marked as a duplicate of this bug. ***
*** Bug 115573 has been marked as a duplicate of this bug. ***
*** Bug 115577 has been marked as a duplicate of this bug. ***
Is it my imagination, or did this start with the checkin for bug 110798?
*** Bug 115612 has been marked as a duplicate of this bug. ***
Is this just crashing because of a null frame?
This happens also on http://home.netscape.com image map links, try right-clicking the "Autos" etc. links on the left. What I am seeing at the top of the stack trace is nsIFrame::GetStyleData(nsStyleStructID eStyleStruct_UserInterface, const nsStyleStruct * & 0x0012e018) line 561 + 3 bytes XULPopupListenerImpl::FireFocusOnTargetContent(nsIDOMNode * 0x03cd3c44) line 331 ...
Blocks: 92172
Keywords: top100
Attached patch null-check fix — — Splinter Review
This null check prevents the crash. However, it seems it is not possible to get focus remain on an image map links (AREA elements) so this is also somewhat hiding that problem.
Adding saari to Cc: Are image map links supposed to work, meaning focus & keyboard navigation?
Ah, this is probably also related to the change I made to stop image maps from misusing the primary frame map.
*** Bug 116160 has been marked as a duplicate of this bug. ***
*** Bug 116165 has been marked as a duplicate of this bug. ***
*** Bug 116537 has been marked as a duplicate of this bug. ***
*** Bug 116785 has been marked as a duplicate of this bug. ***
*** Bug 116923 has been marked as a duplicate of this bug. ***
*** Bug 117049 has been marked as a duplicate of this bug. ***
*** Bug 117166 has been marked as a duplicate of this bug. ***
*** Bug 117372 has been marked as a duplicate of this bug. ***
*** Bug 117384 has been marked as a duplicate of this bug. ***
*** Bug 117423 has been marked as a duplicate of this bug. ***
Why would this crash be Windows-only (which, according to talkback, it is)?
If this were the result of my changes (as I mentioned in comment 21) then the patch on bug 115481 should fix it. Could someone on Windows try that patch?
The patch http://bugzilla.mozilla.org/attachment.cgi?id=63084 on bug 115481 applied to the current trunk prevents this crash from occurring on win2k.
*** Bug 117010 has been marked as a duplicate of this bug. ***
*** Bug 117537 has been marked as a duplicate of this bug. ***
taking
Assignee: hyatt → dbaron
Priority: -- → P1
Target Milestone: --- → mozilla0.9.8
Status: NEW → ASSIGNED
I am getting a crash that sounds like this one. It occurs when I go to http://mail.yahoo.com and right click on an email ad from amazon.com. Build 2001010103 MOZILLA caused an invalid page fault in module GKCONTENT.DLL at 015f:01c10208. Registers: EAX=00000000 CS=015f EIP=01c10208 EFLGS=00010246 EBX=00000000 SS=0167 ESP=0068eb24 EBP=0068eb70 ECX=0305b0e0 DS=0167 ESI=01c7ef88 FS=0fff EDX=0068ea80 ES=0167 EDI=01e81120 GS=0000 Bytes at CS:EIP: 8b 48 18 8b 01 ff 50 40 33 c9 80 78 02 01 53 89 Stack dump: 0000000c 01e81120 00000000 02b0c728 60f77468 02abb400 00000000 00000000 0068eb6c 00000000 02b0c720 02b766e0 02abb3e0 0068eba8 60f75483 01c87da8 GKCONTENT! 01c10208() GKCONTENT! 01c10097() GKCONTENT! 01c0fe81() GKCONTENT! 01c0d2a3() GKCONTENT! 01c0f266() JSDOM! 6061521f() GKCONTENT! 01ba2263() GKCONTENT! 01b963ef() GKCONTENT! 01b963d5() GKCONTENT! 01b963d5() GKCONTENT! 01b963d5() GKCONTENT! 01bc2a46() GKCONTENT! 01c789c2() GKLAYOUT! 60374098() GKLAYOUT! 60373f27() GKVIEW! 604a13d9() GKVIEW! 604a137f() GKVIEW! 604a137f() GKVIEW! 604a7602() GKVIEW! 604a1c0f() GKWIDGET! 604b44ad() GKWIDGET! 604b7369() GKWIDGET! 604b7741() GKWIDGET! 604b49a0() KERNEL32! bff7363b() KERNEL32! bff942e7()
*** Bug 117824 has been marked as a duplicate of this bug. ***
*** Bug 117987 has been marked as a duplicate of this bug. ***
*** Bug 118063 has been marked as a duplicate of this bug. ***
*** Bug 118149 has been marked as a duplicate of this bug. ***
*** Bug 118181 has been marked as a duplicate of this bug. ***
*** Bug 118268 has been marked as a duplicate of this bug. ***
*** Bug 118255 has been marked as a duplicate of this bug. ***
*** Bug 118314 has been marked as a duplicate of this bug. ***
*** Bug 118331 has been marked as a duplicate of this bug. ***
Fix checked in 2001-01-05 07:22 PDT.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
*** Bug 118361 has been marked as a duplicate of this bug. ***
This bug could use some additional keywords or a description that better captures that the crash occurs when right-clicking on an image map. Otherwise, the DUPE bug reports are going to continue to flow in until 0.9.8 is released even though this is fixed. Yes, I'm optimistically assuming that people will search Bugzilla first. :-)
Summary: Crash right clicking on amazon.com [@ XULPopupListenerImpl::FireFocusOnTargetContent] → Crash right clicking on imagemap (at amazon.com, etc.) [@ XULPopupListenerImpl::FireFocusOnTargetContent]
*** Bug 118419 has been marked as a duplicate of this bug. ***
*** Bug 118466 has been marked as a duplicate of this bug. ***
My comment might be unnecessary herein, but a duplicate of this bug, 118063, was reported to be on OS/2. But there is no confirmation of it. Should one of the keywords be changed to pp (platform parity)? Other keyword suggestions: relnote Don't know if this was the most visible topcrash bug.
*** Bug 118511 has been marked as a duplicate of this bug. ***
*** Bug 118547 has been marked as a duplicate of this bug. ***
*** Bug 118569 has been marked as a duplicate of this bug. ***
*** Bug 118580 has been marked as a duplicate of this bug. ***
*** Bug 118751 has been marked as a duplicate of this bug. ***
*** Bug 118961 has been marked as a duplicate of this bug. ***
*** Bug 118996 has been marked as a duplicate of this bug. ***
*** Bug 119064 has been marked as a duplicate of this bug. ***
v
Status: RESOLVED → VERIFIED
*** Bug 120619 has been marked as a duplicate of this bug. ***
*** Bug 120736 has been marked as a duplicate of this bug. ***
Summary: Crash right clicking on imagemap (at amazon.com, etc.) [@ XULPopupListenerImpl::FireFocusOnTargetContent] → Crash right clicking on imagemap (at amazon.com, etc.) - Trunk, M097 [@ XULPopupListenerImpl::FireFocusOnTargetContent]
*** Bug 120761 has been marked as a duplicate of this bug. ***
*** Bug 121383 has been marked as a duplicate of this bug. ***
*** Bug 121416 has been marked as a duplicate of this bug. ***
*** Bug 122691 has been marked as a duplicate of this bug. ***
*** Bug 123037 has been marked as a duplicate of this bug. ***
*** Bug 123115 has been marked as a duplicate of this bug. ***
*** Bug 123429 has been marked as a duplicate of this bug. ***
0.9.8 seems to work fine now, at least as far as this bug goes. Thanks people! It's a great browser.
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
Crash Signature: [@ XULPopupListenerImpl::FireFocusOnTargetContent]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: