Tracking bug for all bugs against plugincheck

RESOLVED DUPLICATE of bug 990857

Status

RESOLVED DUPLICATE of bug 990857
6 years ago
5 years ago

People

(Reporter: espressive, Assigned: espressive)

Tracking

(Depends on: 8 bugs, {meta})

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
This is a tracker that will list all dependency bugs currently logged against plugins.m.o as well as mozilla.com/plugincheck. These need to be addressed during the plugin check rewrite.

Updated

6 years ago
Depends on: 829959
(Assignee)

Updated

6 years ago
Depends on: 830658

Comment 1

6 years ago
Hey Schalk: do you have an estimate timeline on when you want the new plugin check page built in Bedrock? Thanks!
(Assignee)

Comment 2

6 years ago
(In reply to Chris More [:cmore] from comment #1)
> Hey Schalk: do you have an estimate timeline on when you want the new plugin
> check page built in Bedrock? Thanks!

Hey Chris,

So the bulk of the work the goes into the Bedrock side of things are done, I am now working on the Perfidies of the Web side which most of the linked bugs here are related to. It has lagged a little bit as I have been busy on Gaia but, will start to pick it up again from today.

Updated

6 years ago
Depends on: 696003
(Assignee)

Comment 3

6 years ago
Hey Carsten,

Can you please do a functional review of https://www-demo3.allizom.org/b/en-US/plugincheck and log any bugs, or even just a comment on here, with anything you find that is lacking or not working correctly compared to the current live plugincheck page?

Also, only bugs that are not current logged and tracked on this bug. Thanks a lot!
Flags: needinfo?(cbook)
(Assignee)

Updated

6 years ago
Depends on: 836767
Hey Schalk,

yes will do, i'm on buildduty next week, but will do the review next week!

(In reply to Schalk Neethling [:espressive] from comment #3)
> Hey Carsten,
> 
> Can you please do a functional review of
> https://www-demo3.allizom.org/b/en-US/plugincheck and log any bugs, or even
> just a comment on here, with anything you find that is lacking or not
> working correctly compared to the current live plugincheck page?
> 
> Also, only bugs that are not current logged and tracked on this bug. Thanks
> a lot!
Flags: needinfo?(cbook)
(Assignee)

Comment 5

6 years ago
(In reply to Carsten Book [:Tomcat] from comment #4)
> Hey Schalk,
> 
> yes will do, i'm on buildduty next week, but will do the review next week!

Thanks! BTW, if it seems the new plugincheck is not on demo3 let me know, as these demo servers are used by different people at different times so, someone else' code might be pushed there. If so, I will arrange to push this to another demo server and let you know the new URL.

Updated

6 years ago
Depends on: 837966
(Assignee)

Updated

6 years ago
Depends on: 838524
Depends on: 838781
(Assignee)

Comment 6

6 years ago
(In reply to Carsten Book [:Tomcat] from comment #4)
> Hey Schalk,
> 
> yes will do, i'm on buildduty next week, but will do the review next week!
> 

Hey Carsten,

Let me know which day this week or next you will have time to review the new plugincheck page. The new one is not on demo3 anymore so I need to ensure it is pushed there before you review. Thanks
Flags: needinfo?(cbook)

Updated

6 years ago
Keywords: meta
Summary: Tracking bug for all bugs against plugincheck → Tracking bug for all bugs against plugincheck
(In reply to Schalk Neethling [:espressive] from comment #6)
> (In reply to Carsten Book [:Tomcat] from comment #4)
> > Hey Schalk,
> > 
> > yes will do, i'm on buildduty next week, but will do the review next week!
> > 
> 
> Hey Carsten,
> 
> Let me know which day this week or next you will have time to review the new
> plugincheck page. The new one is not on demo3 anymore so I need to ensure it
> is pushed there before you review. Thanks

Hey Schalk, can we do the testrun this week?

cheers,
- Tomcat
Flags: needinfo?(cbook)
(Assignee)

Comment 8

6 years ago
(In reply to Carsten Book [:Tomcat] from comment #7)
> (In reply to Schalk Neethling [:espressive] from comment #6)
> > (In reply to Carsten Book [:Tomcat] from comment #4)
> > > Hey Schalk,
> > > 
> > > yes will do, i'm on buildduty next week, but will do the review next week!
> > > 
> > 
> > Hey Carsten,
> > 
> > Let me know which day this week or next you will have time to review the new
> > plugincheck page. The new one is not on demo3 anymore so I need to ensure it
> > is pushed there before you review. Thanks
> 
> Hey Schalk, can we do the testrun this week?
> 
> cheers,
> - Tomcat

We surely can, let me find out when and where I can have the branch pushed and I will let you know.
(Assignee)

Comment 9

6 years ago
(In reply to Carsten Book [:Tomcat] from comment #7)
> (In reply to Schalk Neethling [:espressive] from comment #6)
> > (In reply to Carsten Book [:Tomcat] from comment #4)
> > > Hey Schalk,
> > > 
> > > yes will do, i'm on buildduty next week, but will do the review next week!
> > > 
> > 
> > Hey Carsten,
> > 
> > Let me know which day this week or next you will have time to review the new
> > plugincheck page. The new one is not on demo3 anymore so I need to ensure it
> > is pushed there before you review. Thanks
> 
> Hey Schalk, can we do the testrun this week?
> 
> cheers,
> - Tomcat

Ok, it is up at https://www-demo3.allizom.org/b/en-US/plugincheck/

Please log any and all bugs you find that is not already logged against the current plugincheck page and link it to this tracker. Thanks a lot!

Comment 10

6 years ago
 
> Ok, it is up at https://www-demo3.allizom.org/b/en-US/plugincheck/
> 
> Please log any and all bugs you find that is not already logged against the
> current plugincheck page and link it to this tracker. Thanks a lot!

Looks great!! How is the weight of the page compared to the legacy version?
(Assignee)

Comment 11

6 years ago
(In reply to Chris More [:cmore] from comment #10)
>  
> > Ok, it is up at https://www-demo3.allizom.org/b/en-US/plugincheck/
> > 
> > Please log any and all bugs you find that is not already logged against the
> > current plugincheck page and link it to this tracker. Thanks a lot!
> 
> Looks great!! How is the weight of the page compared to the legacy version?

Currently it is probably roughly the same except for the fact that the theme and the HTML is now much lighter and cleaner. With that said though, I am also rewriting the Perfedies part of this page and that is going to get much, much lighter which will definitely have an overall positive effect on this page.
hm Schalk, does the current demo also support vulnerable plugins?

I ask because i have on one testsystem a very old flash version 11.5 something and flash is not listed as vulnerable - also i see only see the part of up-to date and unknown plugins.
(Assignee)

Comment 13

6 years ago
(In reply to Carsten Book [:Tomcat] from comment #12)
> hm Schalk, does the current demo also support vulnerable plugins?
> 
> I ask because i have on one testsystem a very old flash version 11.5
> something and flash is not listed as vulnerable - also i see only see the
> part of up-to date and unknown plugins.

It should, let me test this again on my side and see what I can find.
also to add java (which is up-to-date) is not listed in the demo3 page but on the production plugincheck, so seems also missing
(Assignee)

Comment 15

6 years ago
(In reply to Carsten Book [:Tomcat] from comment #14)
> also to add java (which is up-to-date) is not listed in the demo3 page but
> on the production plugincheck, so seems also missing

Can you clarify exactly what you are referring to? It has been agreed in bug790008 that we are only going to report anything related to Java if the plugin is enabled. If it is disabled then we are no longer going to show any messages related to this nor, report any status.
Created attachment 721121 [details]
see screenshot

see screenshot, java is activated but not displayed

Updated

6 years ago
Depends on: 848049
(Assignee)

Comment 17

6 years ago
(In reply to Carsten Book [:Tomcat] from comment #16)
> Created attachment 721121 [details]
> see screenshot
> 
> see screenshot, java is activated but not displayed

Changes pushed, please let me know if you still run into the same problem. Thanks!
(Assignee)

Comment 18

6 years ago
Hey Carsten,

I pushed the updated code to the demo3 server if you want to test again. Thanks!
Flags: needinfo?(cbook)

Comment 19

6 years ago
I just want to pass the kudos for this work! It looks awesome.
(In reply to Schalk Neethling [:espressive] from comment #18)
> Hey Carsten,
> 
> I pushed the updated code to the demo3 server if you want to test again.
> Thanks!

looks great and works great! only a super smal nit :) 

"visit the <A HREF=http://www.apple.com/quicktime>QuickTime</A> Web site." in the plugin description for quicktime :) but all other stuff is great!
Flags: needinfo?(cbook)
(Assignee)

Comment 21

6 years ago
(In reply to Carsten Book [:Tomcat] from comment #20)
> (In reply to Schalk Neethling [:espressive] from comment #18)
> > Hey Carsten,
> > 
> > I pushed the updated code to the demo3 server if you want to test again.
> > Thanks!
> 
> looks great and works great! only a super smal nit :) 
> 
> "visit the <A HREF=http://www.apple.com/quicktime>QuickTime</A> Web site."
> in the plugin description for quicktime :) but all other stuff is great!

So with this bug fixed are you signing of so I can take this live?

Updated

6 years ago
Blocks: 850992

Comment 22

6 years ago
In Bug 850528 I was asked to create a new Bug 850992, and it "needs a new bug marked as a dependency of the new plugincheck, bug". When I mark that Bug as a Dependency (the only thing I have permission to do, and that IS what I was asked to do) I see that it comes up here as a "Block".

I am unsure if that is correct and I do not have permission to add a "Depends on" here (but feel that I should since I have been here for more than a few years).


1. IF Bug 850992 should not be a "block" (as it is the only one) can someone fix that.


2. May I have permission to alter the Restricted Fields on other People's Bug Reports, I used to have this permission over a year ago.


Thanks.
(In reply to Rob from comment #22)
> 1. IF Bug 850992 should not be a "block" (as it is the only one) can someone
> fix that.

I fixed it for you before your comment. 

> 2. May I have permission to alter the Restricted Fields on other People's
> Bug Reports, I used to have this permission over a year ago.

See https://developer.mozilla.org/en-US/docs/What_to_do_and_what_not_to_do_in_Bugzilla and https://bugzilla.mozilla.org/page.cgi?id=get_permissions.html

Note that I think you could have made the change from bug 850992 without additional permissions.

Comment 24

6 years ago
(In reply to Matthew N. [:MattN] from comment #23)
> (In reply to Rob from comment #22)
> > ...
Thank you.
(Assignee)

Updated

6 years ago
Depends on: 864737
(Assignee)

Updated

5 years ago
No longer depends on: 837966
(Assignee)

Comment 25

5 years ago
This bug is now superseded by https://bugzilla.mozilla.org/show_bug.cgi?id=990857
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 990857
You need to log in before you can comment on or make changes to this bug.