1309899 - Release marionette-client 3.2 and marionette-driver 2.1

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[James Graham [:jgraham]]

The latest release is not compatible with current nightly.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It would be also good to get a new release of the driver out. I would like to see bug 1309556 fixed for it.

Andreas, what do we want to do with bug 1308453? It's a must have to get fixed before the next merge. Pushing out to the next release? It's at least a regression of those changes which triggers that new release.

Comment 2

[James Graham [:jgraham]]

FYI the marionette client release is a blocker for me, so I am not keen to scope creep this bug to encompass more unfixed bugs (BTW by "client" I meant testing/marionette/client which aiui is the marionette-driver package).

Comment 3

[Andreas Tolfsen ❲:ato❳]

We can make another release with when a patch for bug 1308453 is ready.  If bug 1309556 is having test issues we can do the same for that.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Those naming conflicts in the tree are annoying => marionette_client == harness && marionette_driver == client!

So it would also be great to see a release of the driver package where we also haven't had a release for a while. We did those both together most of the time in the past, and shouldn't be a problem.

(In reply to Andreas Tolfsen ‹:ato› from comment #3)
> bug 1309556 is having test issues we can do the same for that.

My patch is ready for review and passes all try. Once landed I could check how to create a release of both packages.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Andreas Tolfsen ‹:ato› from comment #3)
> We can make another release with when a patch for bug 1308453 is ready.

Andreas, please keep in mind that with releasing the current code of the driver we will break any version of Firefox below 51 until this bug has been fixed.

Comment 6

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #4)
> Those naming conflicts in the tree are annoying => marionette_client ==
> harness && marionette_driver == client!

The core of the problem is that the Python packages are incorrectly named.  marionette_client does not contain a client, but the test harness.  marionette_driver does not contain the driver implementation, but the client.

The naming of testing/marionette/harness and testing/marionette/client reflects this, until we reach the point where we can give the Python packages sane names.  When you developers work in-tree, which is how most people interact with this code, the name of the directories is more important as they do not directly interact with the Python packages through pip.

> (In reply to Andreas Tolfsen ‹:ato› from comment #3)
> > bug 1309556 is having test issues we can do the same for that.
> 
> My patch is ready for review and passes all try. Once landed I could check
> how to create a release of both packages.

I r+’ed your patch.  Let’s wait for it to hit central before we release.

Comment 7

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1309899 - Release marionette-client 3.2 and marionette-driver 2.1;

Review commit: https://reviewboard.mozilla.org/r/86398/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86398/

Comment 8

[Andreas Tolfsen ❲:ato❳]

Patched https://bugzilla.mozilla.org/show_bug.cgi?id=1308453 and bumped the version numbers here.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8801727 [details]
Bug 1309899 - Release marionette-client 3.2 and marionette-driver 2.1;

https://reviewboard.mozilla.org/r/86398/#review85114

Looks fine to me. Please wait with pushing it to autoland until the dependencies have been fixed. Also make sure to send an email to the tools mailing list with a changelog since the last releases. Thanks.

Comment 10

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #9)
> Looks fine to me. Please wait with pushing it to autoland until the
> dependencies have been fixed. Also make sure to send an email to the tools
> mailing list with a changelog since the last releases. Thanks.

I pushed it to the autoland queue now.

Can you do the PyPI release once it lands on master and post a changelog?

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86bcafe66592
Release marionette-client 3.2 and marionette-driver 2.1; r=whimboo

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I can do those releases for sure. Regarding the changelog I would have to check how to retrieve this information. A bug for former releases should have the appropriate command hopefully.

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/86bcafe66592

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Released packages based on 86bcafe66592 to PyPI:

marionette_driver:
Uploading distributions to https://upload.pypi.org/legacy/
Uploading marionette_driver-2.1.0-py2-none-any.whl
[================================] 45255/45255 - 00:00:03
Uploading marionette_driver-2.1.0.tar.gz
[================================] 38627/38627 - 00:00:01

marionette_client:
Uploading distributions to https://upload.pypi.org/legacy/
Uploading marionette_client-3.2.0-py2-none-any.whl
[================================] 190528/190528 - 00:00:04
Uploading marionette_client-3.2.0.tar.gz
[================================] 154822/154822 - 00:00:02

I will collect the changelog in a bit.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

There wasn't a release for a very long time!! So here the list of changes. Keep in mind that due to the driver tests are under the client, we have a lot of overlap. But I'm not going to sort this out here.

marionette_driver:
------------------
» hg log -M -r 78e21ed06c23:: --template "{desc|firstline}\n" .
Bug 1277672: Lint Marionette Driver python files r=maja_zf
Bug 1277672: Flake8 config for Marionette Driver r=maja_zf
Bug 1281213 - Fix passing of app_args to gecko instance in Marionette client; r=automatedtester
Bug 1025965 - Rename browser.safebrowsing.enabled to browser.safebrowsing.phishing.enabled. r=francios
Bug 787203 - Add emulator and Fennec support to Marionette harness and client; r=automatedtester
Bug 1282570 - In case of in-app restarts Marionette has to update mozprocess for the new process id. r=automatedtester
Bug 1283959 - Add SetWindowSize to return new width and height to comply with WD Spec r=automatedtester
Bug 1282331 - Refactor GetActiveFrame to return WebElement r=automatedtester
Bug 1279243 - Add quit_in_app() to marionette driver. r=maja_zf
Bug 1257476 - Ensure Marionette error classes use correct inheritance. r=ato,automatedtester
Bug 1257476 - Marionette has to force close the process if it doesn't shut down itself. r=automatedtester
Bug 1291658 - Marionette should not assume that there is always a processId in the capabilities available. r=automatedtester, a=tomcat
Bug 1239552 - Disable additional welcome URL in automation; r=automatedtester
Bug 1230151 - Skip out of sync messages in Marionette client; r=automatedtester
Bug 1125834 - Don't print class name of Marionette exceptions twice. r=automatedtester
Bug 1202392 - Improve exception handling and message details in Marionette. r=automatedtester
Bug 1290375 - Marionette has to report the test name and not runner.py for crashes. r=ato
Bug 1293093 - Fix failure message for socket errors in start_session. r=automatedtester
Bug 1293614 - Ensure that Wait().until() aligns as best as possible to the original interval sequence. r=automatedtester
Bug 1293991 - Add remaining process/crash checks for methods of the Marionette class. r=automatedtester
Bug 1293982 - TcpTransport.close() has to force a shutdown of the socket. r=ato
Bug 1296562 - Revert order for crash and socket checks in do_process_check decorator. r=maja_zf
Bug 1284874 - Add 'package' argument to Marionette Test Runner; r=automatedtester
Bug 1294054 - Use marionette.py instead of runner.py in case of crashes with no active test. r=automatedtester
Bug 1280947 - Improve names of JSON marshaling methods in Marionette client; r=automatedtester
Bug 1280947 - Support tuples for script arguments; r=automatedtester
Bug 1271330 - Avoid homepage overrides in the default profile; r=davehunt,whimboo
Bug 1284457 - Reduce default socket timeout for Marionette to 60s r=ato
Bug 1296597 - Allow Marionette to quit a running application instance. r=automatedtester
Bug 1296175 - Remove broken timout code when pushing new permissions. r=ato
Bug 1301661 - Completely remove default value of 360s for socket_timeout r=maja_zf
Bug 1298800 - Add support for callbacks to restart() and quit() methods of Marionette; r=whimboo
Bug 1148220 - Marionette's in_app restart has to send 'quit-application-requested' observer notification. r=automatedtester
Bug 1302707 - Remove Marionette.timeouts from client; r=automatedtester
Bug 1302707 - Add Marionette.set_page_load_timeout and adjust to new driver API; r=automatedtester
Bug 1291687 - Ensure string formatting is using `format()` instead of `%` for all Marionette py files: r=maja_zf
Bug 1274633 - remove windows 10 welcome page, r=MattN
Bug 1309556 - Ensure to correctly shutdown the application for quit/restart when callbacks are used.
Bug 1290372 - wait_for_port() has to return early if instance is not running. r=ato
Bug 1309556 - Ensure to correctly shutdown the application for quit/restart when callbacks are used. r=ato
Bug 1308453 - Backwards compat for old Marionette:timeouts API; r=whimboo
Bug 1309899 - Release marionette-client 3.2 and marionette-driver 2.1; r=whimboo

marionette_client:
------------------
» hg log -M -r 93cc9bcee8c8:: --template "{desc|firstline}\n" .
Bug 1283999 - Rewrite and complement element retrieval tests; r=automatedtester
Bug 1283999 - Rename element retrieval tests to match spec; r=automatedtester
Bug 1283999 - Run element retrieval tests on XHTML documents; r=automatedtester
Bug 787203 - Get Marionette working in Fennec; r=automatedtester
Bug 787203 - Add emulator and Fennec support to Marionette harness and client; r=automatedtester
Bug 1276011 - Fix symbols_path arg not being passed on to runner class. r=automatedtester
Bug 1281915: Skip trying to remove a frame script if there no messageManager r=ato
Bug 1285240: Trim leading and trailing space when finding elements by link text r=ato
Bug 1285240: Update tests to prevent redefinitions r=ato
Bug 1283959 - Add SetWindowSize to return new width and height to comply with WD Spec r=automatedtester
Bug 1284232 - Marshal all HTML and JS collections; r=automatedtester
Bug 1279005 - Refactor BaseMarionetteTestRunner: added new method _is_filename_valid() centralizing test's file name validation logic.; r=maja_zf
Bug 1284405 - Better handling of --socket-timeout cli argument value. r=maja_zf
Bug 1284502 - Marionette harness should log exceptions from run() only once. r=maja_zf
Bug 1287723 - Fix test_screenshot.py for handling secondary chrome windows. r=automatedtester
Bug 1257476 - Ensure Marionette error classes use correct inheritance. r=ato,automatedtester
Bug 1287827 - Part 2. Build changes for removing Loop. r=glandium
Bug 1230151 - Fix skip_unless_protocol ignore decorator; r=automatedtester
Bug 1287591 - The application should not be started and left open if filtering of a single manifest file does not find any test r=automatedtester
Bug 1125834 - Don't print class name of Marionette exceptions twice. r=automatedtester
Bug 1202392 - Improve exception handling and message details in Marionette. r=automatedtester
Bug 1288863: Return platformName and browserVersion as lowercase r=ato
Bug 1280300 - Support navigation by fragment; r=automatedtester
Bug 1290375 - Marionette has to report the test name and not runner.py for crashes. r=ato
Bug 1290966 - Permit introspection into arguments; r=automatedtester
Bug 1290966 - Remove callback function argument from sync scripts; r=automatedtester
Bug 1291643 - Test cleanup after running (possibly empty) manifest; r=whimboo
Bug 1293614 - Ensure that Wait().until() aligns as best as possible to the original interval sequence. r=automatedtester
Bug 1284268 - Add a local ping server; r=maja_zf
Bug 1295776: Disable test_accessibility.py on Windows e10s; r=automatedtester
Bug 1292300 - Make mock_runner fixture do more work; r=maja_zf
Bug 1292300 - Refactor manifest-related tests with fixtures; r=maja_zf
Bug 1292300 - Small readability/typo fixes; r=maja_zf
Bug 1294427 - Fix case in condition on appName in BaseMarionetteTestRunner; r=automatedtester
Bug 1294879 - Pass avd argument to driver_class; r=automatedtester
Bug 1255955 - Rename checkbox test to not conflict with select tests; r=automatedtester
Bug 1255955 - Add support for interacting with <select> elements; r=automatedtester
Bug 1268544: Refactor ProxyAccessible and dependencies; r=tbsaunde
Bug 1284847 - Test args passed to runner/driver classes; r=maja_zf
Bug 1284847 - Add tests for _build_kwargs; r=maja_zf
Bug 1277811 - Fix test_key_actions.py by scrolling element into view before press() is called. r=automatedtester
Bug 1287594 - Allow usage of marionette harness options through mach. r=automatedtester
Bug 1284874 - Add 'package' argument to Marionette Test Runner; r=automatedtester
Bug 1284874 - Add Fennec support to Marionette test skip decorators; r=automatedtester
Bug 1284874 - Update skip decorators and remove dead code in TestScreenOrientation; r=automatedtester
Bug 1284874 - Skip irrelevant Marionette tests on Fennec; r=automatedtester,dustin,gbrown
Bug 1294456 - Regression test. r=automatedtester
Bug 1291796 - Split Marionette harness tests by class; r=maja_zf
Bug 1291796 - Minor fixes to harness unit tests; r=maja_zf
Bug 1296597 - Allow Marionette to quit a running application instance. r=automatedtester
Bug 1300776 - Add testing/marionette/harness to flake8 linter (except mixins, tests) . r=ahal
Bug 1284238 - Split manifest fixture into non/parametrized versions; r=maja_zf
Bug 1284238 - Test that manifest tests are filtered with correct settings; r=maja_zf
Bug 1301153 - Split-up marionette_test module into distinct modules. r=maja_zf
Bug 1285085: Testing for a windows 4x larger than the screen in each dimension should be enough for this test. r=whimboo
Bug 1301661 - Completely remove default value of 360s for socket_timeout r=maja_zf
Bug 1290806 - Fix TestSwitchWindow.test_windows by waiting for the newly opened window. r=maja_zf
Bug 1299207 - Remove unused imports in test_click.py; r=maja_zf
Bug 1301334 - Package Marionette tests via moz.build entries
Bug 1298800 - Add support for callbacks to restart() and quit() methods of Marionette; r=whimboo
Bug 1303497 - Fix failure in test_window_management.py for new window checks. r=maja_zf
Bug 1301334 - Package Marionette tests via moz.build entries r=gps
Bug 1296033: Re-enable test_accessibility.py and test_about_pages.py on Windows e10s; r=automatedtester
Bug 1282833 - Match window position tests to specification; r=automatedtester
Bug 1282833 - Add out of bounds type checks to Set Window Position; r=automatedtester
Bug 1291687 - Ensure string formatting is using `format()` instead of `%` for all Marionette py files: r=maja_zf
Bug 1306772 - Remove DOM/cellbroadcast and related code. r=jst
Bug 1261019 - Part 1: Remove support for running marionette tests as apps; r=maja_zf
Bug 1309723 - Remove DOM/voicemail and related code. r=Ehsan
Bug 1290372 - wait_for_port() has to return early if instance is not running. r=ato
Bug 1309556 - Ensure to correctly shutdown the application for quit/restart when callbacks are used. r=ato
Bug 1309899 - Release marionette-client 3.2 and marionette-driver 2.1; r=whimboo