[Mortar][jsplugins][Meta] PDF support

RESOLVED WONTFIX

Status

()

defect
RESOLVED WONTFIX
3 years ago
7 months ago

People

(Reporter: vchen, Unassigned, NeedInfo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

The meta bug for PDF support
See Also: → 1264552
Depends on: 1265646
Depends on: 1268439
Blocks: 1268829
No longer blocks: 1268829
Depends on: 1268829
Depends on: 1268830
No longer depends on: 1268830
Component: General → PDF Viewer
Depends on: 1269760
Depends on: 1269761
Why is this bug a "Confidential Mozilla Employee Bug"?
Flags: needinfo?(vchen)
Hi Peter, i have a question about input event handling:
I'm not sure if we should use sync |InterfaceMemberCall| when we are dealing with filtering input?
https://github.com/mozilla/flapper.js/blob/master/host/common/ppapi-runtime.jsm#L1228
Since we are using async |InterfaceMemberCall| now and the var handled will always be undefined here.
https://github.com/mozilla/flapper.js/blob/master/host/common/ppapi-runtime.jsm#L1230
ni Peter for comment 2.
Flags: needinfo?(peterv)
Depends on: 1271250
(In reply to Louis Chang [:lochang] from comment #2)
> I'm not sure if we should use sync |InterfaceMemberCall| when we are dealing
> with filtering input?
> https://github.com/mozilla/flapper.js/blob/master/host/common/ppapi-runtime.
> jsm#L1228

Yes, that seems right.
Flags: needinfo?(peterv)
I found the setting steps for pdf (ppapi) with firefox on MAC are not well documented so i summarize the steps as follows:
1. Build Pdf PPAPI (bypass v8 version), apply patch and follow steps on  https://bugzilla.mozilla.org/
show_bug.cgi?id=1264580
2. Update gecko code to latest commit and apply gecko.patch, add mime type then do debug build
   - gecko patch is in flapper.js
   - add MIME type inside dom/plugins/base/nsPluginHost.cpp like https://github.com/mozilla/flapper.js  /blob/master/host/pdf/bootstrap.js#L20
   - debug build have to create mozconfig file and add two lines 
     1) ac_add_options —enable-debug, 
     2) ac_add_options —disable-optimize
3. Build rpc.dylib & Apply patch on https://bugzilla.mozilla.org/show_bug.cgi?id=1265645 (either one can work) to flapper.js
4. Add a ‘ppapipdf.js@mozilla.org' file with one line <flapper.js-src-folder>/host/pdf in your 'path to profile/extensions'
5. install add-on and go to about:config set 'xpinstall.signatures.required' to false 'security.sandbox.content.level' to 0
6. change the preference -> application -> pdf to ppapi (if can’t go to add-on -> plugin activate ppapi first)
(In reply to Peter Van der Beken [:peterv] from comment #4)
> (In reply to Louis Chang [:lochang] from comment #2)
> > I'm not sure if we should use sync |InterfaceMemberCall| when we are dealing
> > with filtering input?
> > https://github.com/mozilla/flapper.js/blob/master/host/common/ppapi-runtime.
> > jsm#L1228
> 
> Yes, that seems right.

Ok thanks, i'll also fix it in bug 1271250.
Depends on: 1269575
Depends on: 1271937
No longer depends on: 1271937
Blocks: 1273059
No longer blocks: 1273059
Depends on: 1273059
Blocks: 1273066
No longer blocks: 1273066
Depends on: 1273066
Depends on: 1273377
Depends on: 1273872
No longer depends on: 1273066
Depends on: 1274906
Depends on: 1274908
Posted file changepage.log
Hi Peter, i just attach the log and the patch which i try to call HandleMessage to ask plugin to change page
. But it gets a channel error and a NS_ERROR_FAILURE. Would you take a look at it?
Flags: needinfo?(peterv)
(In reply to Louis Chang [:lochang] from comment #9)
> Hi Peter, i just attach the log and the patch which i try to call
> HandleMessage to ask plugin to change page
> . But it gets a channel error and a NS_ERROR_FAILURE. Would you take a look
> at it?

This doesn't seem like the right place for debugging (I think this is just a tracking bug), but from your log:

Not implemented: {"__interface":"PPB_MouseInputEvent","__version":"1.1","__method":"GetMovement","mouse_event":5}
    /**
     * 
     */
    PPB_MouseInputEvent_GetMovement: function(json) {
    },

Assertion failure: result.IsEmpty() == !aResult (Expecting a result and didn't get one or vice versa.), at /Volumes/firefoxos/m-inbound/dom/plugins/ipc/PPAPIJSProcessChild.cpp:201
#01: mozilla::plugins::FromPlugin(char const*, bool, char**)[/Volumes/firefoxos/m-inbound/obj-x86_64-apple-darwin15.0.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3d1631b]
...
###!!! [Parent][MessageChannel::Call] Error: Channel error: cannot send/recv

From that point on the channel will give errors.
Flags: needinfo?(peterv)
Depends on: 1271937
Depends on: 1278204
See Also: → 714712
Summary: [Meta] PDF support → [jsplugins][Meta] PDF support
Blocks: 1283028
No longer blocks: 1283028
Depends on: 1283028
Depends on: 1283806
Depends on: 1283811
Depends on: 1286121
Depends on: 1286155
Depends on: 1286491
Depends on: 1286498
Depends on: 1286791
Depends on: 1283816
Depends on: 1287012
Depends on: 1287014
Depends on: 1287016
Depends on: 1287017
Depends on: 1288298
Depends on: 1291541
Depends on: 1291542
Depends on: 1293146
Depends on: 1294385
Depends on: 1295109
Depends on: 1295393
Depends on: 1295856
Depends on: 1296991
Blocks: 1297579
Blocks: 1297582
Depends on: 1298799
No longer depends on: 1287017
No longer depends on: 1287012
Depends on: 1299752
Depends on: 1300705
No longer blocks: 1297579, 1297582
Depends on: 1293406, 1297579, 1297582
Depends on: 1306576
Depends on: 1307709
The Mortar project was announced to public at https://groups.google.com/forum/#!msg/mozilla.dev.planning/j834iDIG3yY/V84Rzw0cEAAJ . Can remove the mozilla-employee-confidential from the all/some bugs related to the project? Also, at what point the access to source code for the public will be allowed?
Depends on: 1309441
Depends on: 1309444
Depends on: 1310083
Depends on: 1310532
No longer depends on: 1309444
Depends on: 1315184
Depends on: 1315606
Depends on: 1316210
Depends on: 1320638
Depends on: 1320639
Depends on: 1321169
Depends on: 1324622
Depends on: 1324623
Depends on: 1324625
Depends on: 1324662
Depends on: 1324708
Depends on: 1324711
Depends on: 1325032
Depends on: 1325568
Depends on: 1325896
Depends on: 1328495
Depends on: 1328543
Depends on: 1328819
No longer depends on: 1328495
Depends on: 1329112
No longer depends on: 1283811
No longer depends on: 1309272
No longer depends on: 1321496
No longer depends on: 1322653
No longer depends on: 1286498
Depends on: 1273472
No longer depends on: 1295109
No longer depends on: 1274908
No longer depends on: 1309441
Depends on: 1268835
No longer depends on: 1273377
No longer depends on: 1324662
No longer depends on: 1325568
Depends on: 1329915
Depends on: 1330182
Depends on: 1330196
Depends on: 1331298
Depends on: 1335664
Depends on: 1338476
Depends on: 1340472
Depends on: 1345050
Depends on: 1345327
Depends on: 1345328
Depends on: 1345330
Depends on: 1345816
Depends on: 1347117
Depends on: 1347416
Depends on: 1347419
No longer depends on: 1345327
No longer depends on: 1335664
Depends on: 1347440
No longer depends on: 1324711
Depends on: jsplugins-base
Depends on: 1344942
Depends on: 1340995
Depends on: 1352111
Depends on: 1356089
Depends on: 1363323
Depends on: 1345786
Summary: [jsplugins][Meta] PDF support → [Mortar][jsplugins][Meta] PDF support
No longer depends on: 1293406
No longer depends on: 1298799
No longer depends on: 1345786
Shouldn't this be WONTFIX?

I don't see anything confidential here, can the confidential tag be removed too?
Wontfix + opening the bug.
Group: mozilla-employee-confidential
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.