1264551 - [Mortar][jsplugins][Meta] PDF support

Status: RESOLVED WONTFIX

(Firefox :: PDF Viewer, defect)

Description

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

The meta bug for PDF support

Comment 1

[Brendan Dahl [:bdahl]]

Why is this bug a "Confidential Mozilla Employee Bug"?

Comment 2

[Louis Chang [:louis]]

Hi Peter, i have a question about input event handling:
I'm not sure if we should use sync |InterfaceMemberCall| when we are dealing with filtering input?
https://github.com/mozilla/flapper.js/blob/master/host/common/ppapi-runtime.jsm#L1228
Since we are using async |InterfaceMemberCall| now and the var handled will always be undefined here.
https://github.com/mozilla/flapper.js/blob/master/host/common/ppapi-runtime.jsm#L1230

Comment 3

[Evelyn Hung]

ni Peter for comment 2.

Comment 4

[Peter Van der Beken [:peterv]]

(In reply to Louis Chang [:lochang] from comment #2)
> I'm not sure if we should use sync |InterfaceMemberCall| when we are dealing
> with filtering input?
> https://github.com/mozilla/flapper.js/blob/master/host/common/ppapi-runtime.
> jsm#L1228

Yes, that seems right.

Comment 5

[Louis Chang [:louis]]

I found the setting steps for pdf (ppapi) with firefox on MAC are not well documented so i summarize the steps as follows:
1. Build Pdf PPAPI (bypass v8 version), apply patch and follow steps on  https://bugzilla.mozilla.org/
show_bug.cgi?id=1264580
2. Update gecko code to latest commit and apply gecko.patch, add mime type then do debug build
   - gecko patch is in flapper.js
   - add MIME type inside dom/plugins/base/nsPluginHost.cpp like https://github.com/mozilla/flapper.js  /blob/master/host/pdf/bootstrap.js#L20
   - debug build have to create mozconfig file and add two lines 
     1) ac_add_options —enable-debug, 
     2) ac_add_options —disable-optimize
3. Build rpc.dylib & Apply patch on https://bugzilla.mozilla.org/show_bug.cgi?id=1265645 (either one can work) to flapper.js
4. Add a ‘[e-mail]' file with one line <flapper.js-src-folder>/host/pdf in your 'path to profile/extensions'
5. install add-on and go to about:config set 'xpinstall.signatures.required' to false 'security.sandbox.content.level' to 0
6. change the preference -> application -> pdf to ppapi (if can’t go to add-on -> plugin activate ppapi first)

Comment 6

[Louis Chang [:louis]]

(In reply to Peter Van der Beken [:peterv] from comment #4)
> (In reply to Louis Chang [:lochang] from comment #2)
> > I'm not sure if we should use sync |InterfaceMemberCall| when we are dealing
> > with filtering input?
> > https://github.com/mozilla/flapper.js/blob/master/host/common/ppapi-runtime.
> > jsm#L1228
> 
> Yes, that seems right.

Ok thanks, i'll also fix it in bug 1271250.

Comment 7

[Louis Chang [:louis]]

Attachment: change_pdf_page.patch

Comment 8

[Louis Chang [:louis]]

Attachment: changepage.log

Comment 9

[Louis Chang [:louis]]

Hi Peter, i just attach the log and the patch which i try to call HandleMessage to ask plugin to change page
. But it gets a channel error and a NS_ERROR_FAILURE. Would you take a look at it?

Comment 10

[Peter Van der Beken [:peterv]]

(In reply to Louis Chang [:lochang] from comment #9)
> Hi Peter, i just attach the log and the patch which i try to call
> HandleMessage to ask plugin to change page
> . But it gets a channel error and a NS_ERROR_FAILURE. Would you take a look
> at it?

This doesn't seem like the right place for debugging (I think this is just a tracking bug), but from your log:

Not implemented: {"__interface":"PPB_MouseInputEvent","__version":"1.1","__method":"GetMovement","mouse_event":5}
    /**
     * 
     */
    PPB_MouseInputEvent_GetMovement: function(json) {
    },

Assertion failure: result.IsEmpty() == !aResult (Expecting a result and didn't get one or vice versa.), at /Volumes/firefoxos/m-inbound/dom/plugins/ipc/PPAPIJSProcessChild.cpp:201
#01: mozilla::plugins::FromPlugin(char const*, bool, char**)[/Volumes/firefoxos/m-inbound/obj-x86_64-apple-darwin15.0.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3d1631b]
...
###!!! [Parent][MessageChannel::Call] Error: Channel error: cannot send/recv

From that point on the channel will give errors.

Comment 11

[Yury Delendik (:yury)]

The Mortar project was announced to public at https://groups.google.com/forum/#!msg/mozilla.dev.planning/j834iDIG3yY/V84Rzw0cEAAJ . Can remove the mozilla-employee-confidential from the all/some bugs related to the project? Also, at what point the access to source code for the public will be allowed?

Comment 12

[Rob Wu [:robwu]]

Shouldn't this be WONTFIX?

I don't see anything confidential here, can the confidential tag be removed too?

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Wontfix + opening the bug.