Open Bug 929478 (tsan) Opened 12 years ago Updated 2 months ago

[meta] Make TSan (ThreadSanitizer) usable with Firefox

Categories

(Core :: Sanitizers, task)

Product:
Core
Component:
Sanitizers
Platform:
All
Linux
Type:
task

Tracking

()

People

(Reporter: decoder, Unassigned)

References

(Depends on 49 open bugs)

Details

(Keywords: meta, sec-want)

This bug is meant for tracking all efforts related to making TSan usable with Firefox and once that is achieved, keeping our builds working and compatible with latest Firefox and TSan features.
Alias: tsan-maintenance
Depends on: 844755
Depends on: 847350
Depends on: 844784
Depends on: 931144
Depends on: 931149
Depends on: 829617
Depends on: 844766
Depends on: 931792
Depends on: 844759
Depends on: 939786
Depends on: 939788
Depends on: 939789
Depends on: 939790
Depends on: 939805
Depends on: 939807
Depends on: 940299
Depends on: 928808
Depends on: 962653
Depends on: 967455
Depends on: 967457
Depends on: 967462
Depends on: 967465
Depends on: 967469
Depends on: 967470
Depends on: 967474
Depends on: 967543
Depends on: 967544
Depends on: 967545
Depends on: 967922
Depends on: 967926
Depends on: 967928
Depends on: 967930
Depends on: 967932
Depends on: 967933
Depends on: 967935
Depends on: 967936
Depends on: 967938
Depends on: 967940
Depends on: 967943
Depends on: 974415
Depends on: 974416
Depends on: 974417
Depends on: 974418
Depends on: 974419
Depends on: 979254
Depends on: 979255
Depends on: 979278
Blocks: 935064
No longer blocks: 935064
Depends on: 935064
Depends on: 979293
Depends on: 1120537
Depends on: 1120545
Depends on: 1120579
Depends on: 1120591
Depends on: 1120611
Depends on: 1120631
Depends on: 1121216
Depends on: 1121669
Depends on: 1121672
Depends on: 1122021
Depends on: 1122070
Depends on: 1131711
Depends on: 1131714
Depends on: 1131715
Depends on: 1131759
Depends on: 1132109
Depends on: 1132170
Depends on: 1132171
Depends on: 1132172
Depends on: 1132201
Depends on: 1132212
Depends on: 1132519
Depends on: 1132572
Depends on: 1132908
Depends on: 1132938
Depends on: 1132966
Depends on: 1133024
Depends on: 1133025
Depends on: 1133028
Depends on: 1133053
Depends on: 1133057
Depends on: 1133064
Depends on: 1136004
Depends on: 1136762
Depends on: 1136844
Depends on: 1136849
Depends on: 1136889
Depends on: 1136922
Depends on: 1136926
Depends on: 1136932
Depends on: 1136952
Depends on: 1133051
Depends on: 1141563
Depends on: 1141565
Depends on: 1141568
Depends on: 1141579
Depends on: 1141583
Depends on: 1141586
Depends on: 1141593
Depends on: 1141644
Depends on: 1141667
Depends on: 1141692
Depends on: 1141741
Depends on: 1148397
Depends on: 1153394
Depends on: 1153409
Depends on: 1153415
Depends on: 1156891
Depends on: 1156909
Depends on: 1156929
Depends on: 1156938
Depends on: 1156966
Depends on: 1156974
Depends on: 1157322
Depends on: 1157323
Depends on: 1157343
Depends on: 1157350
Depends on: 1157382
Depends on: 1157392
Depends on: 1157447
Depends on: 1157454
Depends on: 1158871
Depends on: 1159280
Depends on: 1161170
Depends on: 1190935
Depends on: 1190951
Depends on: 1190969
Depends on: 1190976
Depends on: 1190985
Depends on: 1192031
Depends on: 1192067
Depends on: 1203585
Depends on: 1203655
Depends on: 1203658
Depends on: 1204042
Depends on: 1204043
Depends on: 1216526
Depends on: 1219401
Depends on: 1219403
Depends on: 1219405
Depends on: 1219409
Depends on: 1219418
Depends on: 1219910
Depends on: 1222101
Depends on: 1222782
Depends on: 1244247
Depends on: 1248915
Depends on: 1258183
Depends on: 1280637
Depends on: 1281253
Depends on: 1281275
Depends on: 1281381
Depends on: 1281385
Depends on: 1281292
Depends on: 1266458
Depends on: 1281390
Depends on: 844769
Depends on: 1288596
Assignee: choller → jseward
Depends on: 1291954
No longer depends on: 1288596
Depends on: 1457834
Depends on: 1318398
Depends on: 1367344
Depends on: 1533510
Depends on: 1533521
Depends on: 1533526
Depends on: 1533530
Depends on: 1587065
Depends on: 1587066
Depends on: 1587463
Depends on: 1587509
Depends on: 1587510
Depends on: 1506910
Depends on: 1506812
Depends on: 1587513
Depends on: 1587774
Depends on: 1589839
Depends on: 1588827
Depends on: 1590162
Depends on: 1590423
Depends on: 1590465
Depends on: 1590468
Depends on: 1589934
Depends on: 1592250
Depends on: 1592259
Depends on: 1598342
Depends on: 1580288
Depends on: 1585170
Depends on: 1548822
Depends on: 1600312
Depends on: 1600320
Depends on: 1600567
Depends on: 1600572
Depends on: 1600594
Depends on: 1600889
Depends on: 1600895
Depends on: 1601286
Depends on: 1601597
Depends on: 1601600
Depends on: 1601620
Depends on: 1601632
Depends on: 1601717
Depends on: 1601738
Depends on: 1601940
Depends on: 1601980
Depends on: 1602009
Depends on: 1602026
Depends on: 1602313
Depends on: 1603504
Depends on: 1606635
Depends on: 1606643
Depends on: 1606647
Depends on: 1606651
Depends on: 1606661
Depends on: 1606800
Depends on: 1606803
Depends on: 1606804
Depends on: 1606807
Depends on: 1606813
Depends on: 1606859
Depends on: 1606860
Depends on: 1606864
Depends on: 1607005
Depends on: 1607008
Depends on: 1607134
Depends on: 1607138
Depends on: 1607142
Depends on: 1607146
Depends on: 1607153
Depends on: 1607202
Depends on: 1607212
Depends on: 1607215
Depends on: 1607218
Depends on: 1607221
Depends on: 1607224
Depends on: 1607426
Depends on: 1607444
Depends on: 1607446
Depends on: 1607449
Depends on: 1607588
Depends on: 1607704
Depends on: 1607706
Depends on: 1607712
Depends on: 1607762
Depends on: 1607764
Depends on: 1608068
Depends on: 1608357
Depends on: 1608462
Depends on: 1609400
Depends on: 1612054
Depends on: 1612707
Depends on: tsan-tests-basic
Depends on: 1612713
Depends on: 1612740
Depends on: 1613384
Depends on: 1612212
Depends on: 1614605
Depends on: 1614637
Depends on: 1614646
Depends on: 1614697
Depends on: 1614706
Depends on: 1614708
Depends on: 1615014
Depends on: 1615017
Depends on: 1615045
Depends on: 1615121
Depends on: 1615125
Depends on: 1615228
Depends on: 1615275
Depends on: 1615265
Depends on: 1615569
Depends on: 1615725
Depends on: 1616342
Depends on: 1616120
Depends on: 1616027
Depends on: 1615608
Depends on: 1616507
Alias: tsan-maintenance → tsan
Assignee: jseward → nobody
Component: Security Assurance: Applications → Sanitizers
Product: mozilla.org → Core
Version: other → Trunk
Keywords: meta
Summary: Make TSan (ThreadSanitizer) usable with Firefox → [meta] Make TSan (ThreadSanitizer) usable with Firefox

Chiming into this bug, please direct me to a more appropriate bug if there exists one.

I've noticed that tsan is currently running on linux64 docker image. This has been phased out for the most part on mozilla-central, with tests now running with ubuntu1804-test docker image.

I have a push where I made the necessary changes to have tsan run with ubuntu1804-test docker image, and I have some failures:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&tier=1%2C2%2C3&revision=e41b65c04476a324e12f6699f2bb7b6b3fbed695

xpcshell

  • X2 chunk reports a bunch of TEST-UNEXPECTED-FAIL that I assume are legitimate failures (i.e not slow tests).

mochitest-plain

  • a persistent failure of toolkit/content/tests/widgets/test_videocontrols.html can be seen in chunk 4.
  • multiple failures are observed in chunk 5, retriggers are underway.

I'd like to have all of tsan migrated over to use ubuntu1804 before the list of test suites grows. Should I skip all of the failing tests with skip-if = tsan?

Flags: needinfo?(choller)
Depends on: 1621195
Flags: needinfo?(choller)
Depends on: 1623034
Depends on: 1623541
Depends on: 1623542
Depends on: 1624563
Depends on: 1624842
Depends on: 1624897
Depends on: 1627572
Depends on: 1627683
Depends on: 1628780
Depends on: 1637977
Depends on: 1642653
Depends on: 1642906
Depends on: 1647378
Depends on: 1651446
Depends on: 1651449
Depends on: 1651509
Depends on: CVE-2020-15668
Depends on: mochitest_media_tsan
Depends on: 1651770
Depends on: 1652046
Depends on: 1652093
Depends on: 1652118
Depends on: 1652116
Depends on: 1652113
Depends on: 1652107
Depends on: 1652103
Depends on: 1652133
Depends on: 1652135
Depends on: 1652171
Depends on: 1652174
Depends on: 1652300
Depends on: 1627172
Depends on: 1647403
Depends on: 1629080
Depends on: 1645590
Depends on: 1633065
Depends on: 1637878
Depends on: 1647038
Depends on: 1643087
Depends on: 1644383
Depends on: 1627951
Depends on: 1635310
Depends on: 1648245
Depends on: 1638718
Depends on: 1643792
Depends on: 1646052
Depends on: 1630547
Depends on: 1642488
Depends on: 1633599
Depends on: 1647406
Depends on: 1647759
Depends on: 1645391
Depends on: 1644386
Depends on: 1629128
Depends on: 1647702
Depends on: 1647398
Depends on: 1647411
Depends on: 1636095
Depends on: 1633749
Depends on: 1633880
Depends on: 1647417
Depends on: 1645696
Depends on: 1640066
Depends on: 1644388
Depends on: 1629514
Depends on: 1632215
Depends on: 1647392
Depends on: 1637707
Depends on: 1630595
Depends on: 1648317
Depends on: 1642884
Depends on: 1637837
Depends on: 1647395
Depends on: 1645710
Depends on: 1630649
Depends on: 1626534
Depends on: 1644387
Depends on: 1649436
Depends on: 1642314
Depends on: 1649430
Depends on: 1631140
Depends on: 1626631
Depends on: 1640903
Depends on: 1642230
Depends on: 1647413, 1638212
Depends on: 1640332
Depends on: 1640445
Depends on: 1633239
Depends on: 1627487
Depends on: 1642086
Depends on: 1629299
Depends on: 1648860
Depends on: 1655518
Depends on: 1656266, 1656329, 1656268
Depends on: 1616462
Depends on: 1661527
Depends on: 1656326
Depends on: 1664534
Depends on: 1664535
Depends on: 1664536
Depends on: 1664547
Depends on: 1664799
Depends on: 1664802
Depends on: 1664803
Depends on: 1664831
Depends on: 1670982
Depends on: 1671572
Depends on: 1671574
Depends on: 1671577
Depends on: 1671601
Depends on: 1671691
Depends on: 1671692
Depends on: 1671923
Depends on: 1671931
Depends on: 1672155
Depends on: 1672162
Depends on: 1672230
Depends on: 1672253
Depends on: 1615123
Depends on: 1674467
Depends on: 1674770
Depends on: 1674773
Depends on: 1674776
Depends on: 1674835
Depends on: 1676257
Depends on: mochitest-bc-tsan
Depends on: 1677913
Depends on: 1680285
Depends on: 1680389
Depends on: 1680446
Depends on: 1681205
Depends on: 1681297
Depends on: 1681950
Depends on: 1682344
Depends on: 1682544
Depends on: 1682143
Depends on: 1682723
Depends on: 1682861
Depends on: 1682928
Depends on: 1682932
Depends on: 1682938
Depends on: 1682948
Depends on: 1682958
Depends on: 1683404
Depends on: 1683407
Depends on: 1683410
Depends on: 1683417
Depends on: 1683439
Depends on: 1659420
Depends on: 1676905
Depends on: 1647628
Depends on: 1683730
Depends on: 1683973
Depends on: 1685440
Depends on: 1685837
Depends on: 1683475
Depends on: 1685838
Depends on: 1686153
Depends on: 1686154
Depends on: 1686156
Depends on: 1686158
Depends on: 1686159
Depends on: 1685857
Depends on: 1685752
Depends on: 1681547
Depends on: 1685375
Depends on: 1686637
Depends on: 1687001
No longer depends on: 1281390
Depends on: 1690370
Depends on: 1682955
Depends on: 1692067
Depends on: 1692068
Depends on: 1692120
Depends on: 1696442
Depends on: 1699771
Depends on: 1702648
Depends on: 1703191
Depends on: 1688716
Depends on: 1704225
Depends on: CVE-2021-29952
Depends on: 1704229
Depends on: 1704647
Depends on: 1709499
Depends on: 1709502
Depends on: 1712186
Depends on: 1712787
Depends on: 1713294
Depends on: 1715524
Depends on: 1714232
Depends on: 1706560
Depends on: 1717728
Depends on: 1718043
Depends on: 1717781
Depends on: 844757
Depends on: 1721342
Depends on: 1723176
Depends on: 1723170
Depends on: 1723142
Depends on: 1723351
Depends on: 1723321
Depends on: 1723636
Depends on: 1723770
Depends on: 1723730
Depends on: 1724101
Depends on: 1724107
Depends on: 1724252
Depends on: 1701242
Depends on: 1724499
Depends on: 1724318
Depends on: 1724672
Depends on: 1724817
Depends on: 1726898
Depends on: 1727225
Depends on: 1727005
Depends on: 1728347
Depends on: 1728592
Depends on: 1728715
Depends on: CVE-2021-32810
Depends on: 1730031
Depends on: 1367103
Depends on: 1732309
Depends on: 1733613
Depends on: 1712671
Depends on: 1733908
Depends on: 1736440
Depends on: 1737901
Depends on: 1738170
Depends on: 1739504
Depends on: 1739510
Depends on: 1743214
Depends on: 1743221
Depends on: 1744900
Depends on: 1745613
Depends on: 1745805
Depends on: 1746546
Depends on: 1750044
Depends on: 1751583
Depends on: 1752844
Depends on: 1754554
Depends on: 1754608
Depends on: 1650601, 1669273, 1691557
No longer depends on: 1752963
Depends on: 1758223
No longer depends on: 1758057
Depends on: 1759794
Depends on: 1764410
Depends on: 1765782
See Also: → 1767483
Depends on: 1771263
Depends on: 1772463
Depends on: 1774773
Depends on: 1779729
Depends on: CVE-2022-42930
Depends on: 1792619
Severity: normal → S3
Depends on: 1796753
Depends on: 1798849
Depends on: 1804808
Depends on: 1728042
Depends on: 1805442
Depends on: 1805457
Depends on: 1805536
Depends on: 1805819
Depends on: 1805820
Depends on: 1806222
Depends on: 1806483
Depends on: 1806832
Depends on: 1806934
Depends on: 1806936
Depends on: 1806946
Depends on: 1807000
Depends on: 1807004
Depends on: 1807157
Depends on: 1807238
Depends on: 1808235
Depends on: 1808236
Depends on: 1808816
Depends on: 1806852
Depends on: 1811047
Depends on: 1813811
Depends on: 1815998
Depends on: 1816713
Depends on: 1819503
Depends on: 1824768
Depends on: 1825170
Depends on: 1825171
Depends on: 1826258
Depends on: 1826684
Depends on: 1829445
Depends on: 1837550
Depends on: 1835935
Depends on: 1861252
Depends on: 1881088
Depends on: 1887870
No longer depends on: 1887870
Depends on: 1916662
Depends on: 1922578

I am not sure if this is the proper bugzilla, but I thought this is seen by many who try to fix TSAN issues.

Hi I have been trying to detect and fix possible thread races in thunderbird.
I use TSAN built using clang locally.
However, I use ordinary GCC toolchain for memory check using valgrind.
So in a sense I am using mixed binary tool chain with different object directories for different target (ordinary, ASAN TSAN, etc.)

I noticed that using GCC-15 (and possibly GCC-14) I noticed the following type of warning in my local xpcshell test.
As you can see, they are extremely useful for detecting possible deadlock issue after I inserted monitor calls maybe too eagerly without checking cyclic locaking to fix TSAN issues found by
TSAN version run locally.

14:46.60 INFO xpcshell-maildir.toml:comm/mailnews/imap/test/unit/test_dontStatNoSelect.js | Starting endTest
14:46.60 INFO (xpcshell/head.js) | test endTest pending (2)
14:46.60 PASS endTest - [endTest : 113] 2 == 2
14:46.60 pid:2637614 {debug} SetSpec succeeded. : aSpec=imap://user@localhost:34595/folderstatus%3E/folder%201
14:46.60 pid:2637614 {debug} SetSpec succeeded. : aSpec=moz-nullprincipal:{f53034e1-92a5-481a-9bf7-3d8b0f72cdb0}
14:46.61 INFO (xpcshell/head.js) | test run_next_test 3 finished (2)
14:46.61 INFO (xpcshell/head.js) | test run_next_test 4 pending (2)
14:46.61 INFO (xpcshell/head.js) | test endTest finished (2)
14:46.61 INFO (xpcshell/head.js) | test run_next_test 4 finished (1)
14:46.61 INFO exiting test
14:46.63 pid:2637614 ###!!! ERROR: Potential deadlock detected:
14:46.63 pid:2637614 === Cyclical dependency starts at
14:46.63 pid:2637614 --- ReentrantMonitor : nsImapProtocol.mMonitor (currently acquired)
14:46.63 pid:2637614  calling context
Initializing stack-fixing for the first stack frame, this may take a while...
15:21.28 pid:2637614     #01: mozilla::ReentrantMonitor::Enter() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/xpcom/threads/BlockingResourceBase.cpp:448)
15:21.28 pid:2637614     #02: nsImapProtocol::TellThreadToDie() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:1348)
15:21.28 pid:2637614     #03: nsImapProtocol::CreateNewLineFromSocket() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:5240)
15:21.29 pid:2637614     #04: nsImapServerResponseParser::GetNextLineForParser(char**) (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapServerResponseParser.cpp:99)
15:21.30 pid:2637614     #05: nsImapGenericParser::AdvanceToNextLine() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapGenericParser.cpp:120)
15:21.31 pid:2637614     #06: nsImapGenericParser::AdvanceToNextToken() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapGenericParser.cpp:95)
15:21.31 pid:2637614     #07: nsImapServerResponseParser::ParseIMAPServerResponse(char const*, bool, char*) (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapServerResponseParser.cpp:206)
15:21.31 pid:2637614     #08: nsImapProtocol::AuthLogin(char const*, nsTString<char16_t> const&, unsigned long) [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:6294)
15:21.31 pid:2637614     #09: nsImapProtocol::TryToLogon() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:8914)
15:21.31 pid:2637614     #10: mozilla::detail::RunnableFunction<nsImapProtocol::ProcessCurrentURL()::{lambda()#1}>::Run() (/NEW-SSD/moz-obj-dir/objdir-tb3/dist/include/nsThreadUtils.h:549)
15:21.31 pid:2637614 --- Next dependency:
15:21.31 pid:2637614 --- ReentrantMonitor : imapThreadDeath (currently acquired)
15:21.31 pid:2637614  calling context
15:21.31 pid:2637614     #01: mozilla::ReentrantMonitor::Enter() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/xpcom/threads/BlockingResourceBase.cpp:450)
15:21.31 pid:2637614     #02: nsImapProtocol::CreateNewLineFromSocket() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:5239)
15:21.31 pid:2637614     #03: nsImapServerResponseParser::GetNextLineForParser(char**) (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapServerResponseParser.cpp:99)
15:21.31 pid:2637614     #04: nsImapGenericParser::AdvanceToNextLine() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapGenericParser.cpp:120)
15:21.31 pid:2637614     #05: nsImapGenericParser::AdvanceToNextToken() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapGenericParser.cpp:95)
15:21.31 pid:2637614     #06: nsImapServerResponseParser::ParseIMAPServerResponse(char const*, bool, char*) (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapServerResponseParser.cpp:206)
15:21.31 pid:2637614     #07: nsImapProtocol::AuthLogin(char const*, nsTString<char16_t> const&, unsigned long) [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:6294)
15:21.31 pid:2637614     #08: nsImapProtocol::TryToLogon() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:8914)
15:21.31 pid:2637614     #09: mozilla::detail::RunnableFunction<nsImapProtocol::ProcessCurrentURL()::{lambda()#1}>::Run() (/NEW-SSD/moz-obj-dir/objdir-tb3/dist/include/nsThreadUtils.h:549)
15:21.31 pid:2637614     #10: ??? (/NEW-SSD/moz-obj-dir/objdir-tb3/dist/bin/libxul.so + 0xbe488f3)
15:21.31 pid:2637614 === Cycle completed at
15:21.31 pid:2637614 --- ReentrantMonitor : nsImapProtocol.mMonitor (currently acquired)
15:21.31 pid:2637614  calling context
15:21.31 pid:2637614     #01: mozilla::ReentrantMonitor::Enter() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/xpcom/threads/BlockingResourceBase.cpp:448)
15:21.31 pid:2637614     #02: nsImapProtocol::TellThreadToDie() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:1348)
15:21.31 pid:2637614     #03: nsImapProtocol::CreateNewLineFromSocket() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:5240)
15:21.31 pid:2637614     #04: nsImapServerResponseParser::GetNextLineForParser(char**) (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapServerResponseParser.cpp:99)
15:21.31 pid:2637614     #05: nsImapGenericParser::AdvanceToNextLine() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapGenericParser.cpp:120)
15:21.31 pid:2637614     #06: nsImapGenericParser::AdvanceToNextToken() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapGenericParser.cpp:95)
15:21.31 pid:2637614     #07: nsImapServerResponseParser::ParseIMAPServerResponse(char const*, bool, char*) (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapServerResponseParser.cpp:206)
15:21.31 pid:2637614     #08: nsImapProtocol::AuthLogin(char const*, nsTString<char16_t> const&, unsigned long) [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:6294)
15:21.31 pid:2637614     #09: nsImapProtocol::TryToLogon() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:8914)
15:21.31 pid:2637614     #10: mozilla::detail::RunnableFunction<nsImapProtocol::ProcessCurrentURL()::{lambda()#1}>::Run() (/NEW-SSD/moz-obj-dir/objdir-tb3/dist/include/nsThreadUtils.h:549)
15:21.31 pid:2637614 ###!!! Deadlock may happen NOW!
15:21.31 pid:2637614 \x07[Parent 2637614, IMAP] ###!!! ASSERTION: Potential deadlock detected:
15:21.31 pid:2637614 Cyclical dependency starts at
15:21.31 pid:2637614 ReentrantMonitor : nsImapProtocol.mMonitor (currently acquired)
15:21.31 pid:2637614     #01: mozilla::ReentrantMonitor::Enter() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/xpcom/threads/BlockingResourceBase.cpp:448)
15:21.31 pid:2637614     #02: nsImapProtocol::TellThreadToDie() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:1348)
15:21.31 pid:2637614     #03: nsImapProtocol::CreateNewLineFromSocket() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:5240)
15:21.31 pid:2637614     #04: nsImapServerResponseParser::GetNextLineForParser(char**) (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapServerResponseParser.cpp:99)
15:21.31 pid:2637614     #05: nsImapGenericParser::AdvanceToNextLine() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapGenericParser.cpp:120)
15:21.31 pid:2637614     #06: nsImapGenericParser::AdvanceToNextToken() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapGenericParser.cpp:95)
15:21.31 pid:2637614     #07: nsImapServerResponseParser::ParseIMAPServerResponse(char const*, bool, char*) (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapServerResponseParser.cpp:206)
15:21.31 pid:2637614     #08: ???[/NEW-SSD/moz-obj-dir/objdir-tb3/dist/bin/libxul.so +0x
15:21.32 pid:2637614 #01: NS_DebugBreak.cold (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/xpcom/base/nsDebugImpl.cpp:511)
15:21.32 pid:2637614 #02: mozilla::BlockingResourceBase::CheckAcquire() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/xpcom/threads/BlockingResourceBase.cpp:279)
15:21.32 pid:2637614 #03: mozilla::ReentrantMonitor::Enter() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/xpcom/threads/BlockingResourceBase.cpp:448)
15:21.32 pid:2637614 #04: nsImapProtocol::TellThreadToDie() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:1348)
15:21.32 pid:2637614 #05: nsImapProtocol::CreateNewLineFromSocket() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:5240)
15:21.32 pid:2637614 #06: nsImapServerResponseParser::GetNextLineForParser(char**) (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapServerResponseParser.cpp:99)
15:21.32 pid:2637614 #07: nsImapGenericParser::AdvanceToNextLine() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapGenericParser.cpp:120)
15:21.32 pid:2637614 #08: nsImapGenericParser::AdvanceToNextToken() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapGenericParser.cpp:95)
15:21.32 pid:2637614 #09: nsImapServerResponseParser::ParseIMAPServerResponse(char const*, bool, char*) (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapServerResponseParser.cpp:206)
15:21.32 pid:2637614 #10: nsImapProtocol::AuthLogin(char const*, nsTString<char16_t> const&, unsigned long) [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:6294)
15:21.32 pid:2637614 #11: nsImapProtocol::TryToLogon() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:8914)
15:21.32 pid:2637614 #12: mozilla::detail::RunnableFunction<nsImapProtocol::ProcessCurrentURL()::{lambda()#1}>::Run() (/NEW-SSD/moz-obj-dir/objdir-tb3/dist/include/nsThreadUtils.h:549)
15:21.32 pid:2637614 #13: ??? (/NEW-SSD/moz-obj-dir/objdir-tb3/dist/bin/libxul.so + 0xbe488f3)
15:21.32 pid:2637614 #14: nsImapProtocol::ProcessCurrentURL() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:2063)
15:21.32 pid:2637614 #15: nsImapProtocol::ImapThreadMainLoop() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:1607)
15:21.32 pid:2637614 #16: nsImapProtocol::RunImapThreadMainLoop() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:1124)
15:21.32 pid:2637614 #17: nsImapProtocolMainLoopRunnable::Run() (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/imap/src/nsImapProtocol.cpp:460)
15:21.32 pid:2637614 #18: nsThread::ProcessNextEvent(bool, bool*) [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/xpcom/threads/nsThread.cpp:1159)
15:21.32 pid:2637614 #19: NS_ProcessNextEvent(nsIThread*, bool) (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/xpcom/threads/nsThreadUtils.cpp:461)
15:21.32 pid:2637614 #20: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/ipc/glue/MessagePump.cpp:299)
15:21.32 pid:2637614 #21: MessageLoop::Run() [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/ipc/chromium/src/base/message_loop.cc:344)
15:21.32 pid:2637614 #22: nsThread::ThreadFunc(void*) [clone .cold] (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/xpcom/threads/nsThread.cpp:375)
15:21.34 pid:2637614 #23: _pt_root (/NEW-SSD/NREF-COMM-CENTRAL/mozilla/nsprpub/pr/src/pthreads/ptthread.c:198)
15:21.37 pid:2637614 #24: ??? (/lib/x86_64-linux-gnu/libc.so.6 + 0x92b7b)
15:21.37 pid:2637614 #25: ??? (/lib/x86_64-linux-gnu/libc.so.6 + 0x1107b8)
15:21.37 pid:2637614 #26: ??? (???:???)

There are definitely some data race issues regarding IMAP buffer code handling in thunderbird and it seems that
I inserted monitor call inappropriately and this helps me track down the strange timeout issue which I found locally and on treeherder.

But I have absolutely no idea which option during the compling or which libraries I used during linking were responsible for the generation of these runtime warnings.
I saw this type of message once while I used gcc-14 about a year ago, but have not seen this until about three days ago.
Now I realize that I may have mixed up the ordinary compiled objects (using GCC for non-TSAN built object) and then linked it with libraries that are meant for TSAN build, even.
But if so, that accidental mistake may have somehow produced very nice runtime warning messages.

My question:
Has anyone seen similar messages before, and if so, can you recall how you compile and link the binaries?

I feel that this deadlock detection at runtime is SO USEFUL and ought to be part of a rebular testing.
TSAN does not seem to detect this if I am not mistaken (but it may do. I have updated clang support libraries lately using }mach bootstrap|
because somehow after I could not develop and test for a copule of couple of months, around December, my local build failed and I had to do some serious code clean up with a few fals starts after Jan 10th. Then I noticed these nice runtime warning messages
which I once saw and could not reproduce until a few days ago. this suggessts maybe an update C++/C runtime libraries (possibly for TSAN use, which I may have linked accidentally to my normal build.)

If there is a better place to ask these questions, I will welcome any pointers to such places.

TIA

(In reply to ISHIKAWA, Chiaki from comment #2)

I am not sure if this is the proper bugzilla, but I thought this is seen by many who try to fix TSAN issues. ... [omission] ...
My question:
Has anyone seen similar messages before, and if so, can you recall how you compile and link the binaries?

Sorry for the noise.
After searching for "ASSERTION: Potential deadlock detected: Cyclical dependency starts at" using google, I now realize the particular message
I quoted in my comment 2 comes from XPCOM code in moazilla-central, I mean firefox-main.

https://searchfox.org/firefox-main/source/xpcom/threads/BlockingResourceBase.cpp#211

So that probably detected the dormant deadlock issue which I have introduced in November last year and not realized yet then.
The similar deadlock detection code in
https://searchfox.org/firefox-main/source/xpcom/threads/BlockingResourceBase.cpp#265
probably generated the message that I saw about a year ago, and after code modification, that problem must have disappeared.

The above scenario fits my observation of the deadlock warning one year ago and a few days ago. (It could be that the first code detected the
error last year, but I often lagged behind the source code update so that I can chase a bug in a known source tree for extended days.)

With the understanding that there is XPCOM runtime check,
I can insert monitor calls to fix TSAN issues rather too eagerly and let the runtime code to detect potential deadlocks.
Not ideal, but very workable to fix legacy thunderbird imap code.

One point I noticed. TSAN runtime library itself may introduce enough timing variance to mask/hide or cause timing related issues.
I checked my local log files and found the message appear in a couple of logfiles that were produced by TSAN version **** xpchsell test runs on April 2, 2025.
I ran three tests on that day, and two files recorded the potential deadlock and the other did not. I am not sure if I fixed the problem by modifying the code or not. TSAN issues are hard to erase, but this runtime check of potential deadlock is very useful.
I was led to believe that if I use TSAN build, this message was NOT produced, but I was probably wrong. It was just a concidence that I did not see them during TSAN testing (either due to timing differences and/or the culprit issue had been fixed incidentally.)

Again, I am sorry for the noise, but when I simply insert the whole message lines nothing showed up in google search, and only afterI trimmed the message lines and fed them to google, meaningful result appeared.

You need to log in before you can comment on or make changes to this bug.